Skip to content

no error when nse() with change#406

Merged
joente merged 2 commits intomainfrom
nse
Mar 19, 2025
Merged

no error when nse() with change#406
joente merged 2 commits intomainfrom
nse

Conversation

@joente
Copy link
Copy Markdown
Member

@joente joente commented Mar 19, 2025

Description

Currently, ThingsDB returns with the following error when a change is enforced and the nse() function is being called:

"function nse failed; at least one side-effect is enforced"

This can be annoying, as you sometimes want to create a closure which by itself does not require a change, but can be used in a scenario where a change is perfectly fine.

This PR removes the error and let nse() silently continue if a change exists.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test collection functions

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@joente joente self-assigned this Mar 19, 2025
@joente joente merged commit 3049675 into main Mar 19, 2025
1 check passed
@joente joente deleted the nse branch October 25, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant