Support alternate link sources#1516
Merged
hjiangsu merged 4 commits intothunder-app:developfrom Sep 26, 2024
Merged
Conversation
Member
Author
|
I pushed a small change which ensures that navigation to alternate sources once you're already in a webview occurs within that same webview instead of pushing a new one on top. |
|
This is cool |
hjiangsu
approved these changes
Sep 26, 2024
Member
hjiangsu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this feature 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was inspired by the following post: https://lemmy.world/post/18198313
In that post a screenshot of the Tesseract front-end was shown, demonstrating how it provides links to "Alternate Sources" for a given article link. The sources that Tesseract provides are these:
Notes
BottomSheetListPickerto a manually-constructed list ofPickerItems) I did a back-and-forth comparison to ensure that the layout looks exactly the same as before.I have decided to implement this feature with the following sources.
I excluded the following sources.
The good news is that new sources are super easy to add (one line of code) so we can be totally flexible there.
The alternate sources can be accessed from the following places.
In all cases, the alternative links are displayed using the same bottom sheet widget, to reduce duplicate code
qemu-system-x86_64_DrxTLZXUQX.mp4