Skip to content

Add possibility to override config#1

Merged
tiangolo merged 2 commits intotiangolo:masterfrom
pyropy:feature/config-override
May 5, 2020
Merged

Add possibility to override config#1
tiangolo merged 2 commits intotiangolo:masterfrom
pyropy:feature/config-override

Conversation

@pyropy
Copy link
Copy Markdown
Contributor

@pyropy pyropy commented May 2, 2020

Sometimes frontend devs just want that camelCase rather then your sweet snake_case, so you need to add custom pydantic config to your models :/

@codecov
Copy link
Copy Markdown

codecov bot commented May 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1021a05). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master        #1   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         2           
  Lines             ?        79           
  Branches          ?         0           
==========================================
  Hits              ?        79           
  Misses            ?         0           
  Partials          ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1021a05...4352a31. Read the comment docs.

@tiangolo tiangolo merged commit 6a8a986 into tiangolo:master May 5, 2020
@tiangolo
Copy link
Copy Markdown
Owner

tiangolo commented May 5, 2020

Great, thanks! 🚀

I just added tests for it and it's now merged 🎉

@pyropy
Copy link
Copy Markdown
Contributor Author

pyropy commented May 5, 2020

@tiangolo Sorry I havent written any tests. This is my first real open-source contribution, thank you for the merge :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants