Skip to content

Assignment two #3

Open
tintingong wants to merge 5 commits intomainfrom
assignment-two
Open

Assignment two #3
tintingong wants to merge 5 commits intomainfrom
assignment-two

Conversation

@tintingong
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@efantinatti efantinatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Anna Wong

Session 1:
1 - Missing diagrams and explanation about type 1 and type 2 tables. Check if the files were uploaded because it seems tagged in the .md file but not uploaded to github.

Session 2:
2 - Partial.
--Windowed Functions - Q3: Query won't display the correct results. Check what you are counting against what is being asked in the question.
-- UNION - Q3: Query is not showing correct results.

Session 3:
3 - Partial.
-- UNION - Q4: Query result is not OK. Should show only one result per part. Consider using RANK().

Final:
4 - Check the aforementioned points prior to merging your feature branch 'assignment-two' to 'main'.

Mark: 20 points.

@tintingong
Copy link
Copy Markdown
Owner Author

Session 1: - upload again. I think it works this time, please check

@efantinatti
Copy link
Copy Markdown

Hi @tintingong I still can't see the images.

@tintingong
Copy link
Copy Markdown
Owner Author

I have uploaded the ERD again, please double check. Thanks!

@efantinatti
Copy link
Copy Markdown

Thanks @tintingong marked with 64 points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants