Skip to content

Java.Lang.Thread#258

Merged
tiny-express merged 48 commits intodevelopmentfrom
java.lang.Thread
Mar 25, 2018
Merged

Java.Lang.Thread#258
tiny-express merged 48 commits intodevelopmentfrom
java.lang.Thread

Conversation

@sonda2208
Copy link
Copy Markdown
Contributor

@sonda2208 sonda2208 commented Sep 18, 2017

No description provided.

minh1302 and others added 19 commits August 19, 2017 09:41
@minh1302
#231 Defined private, public variable. Clean unuse code
4b07025
@minh1302
#231 Added test + Built Constructor, Getter + Setter of name, priorit…
8c5b250 
…y, daemon. Thread::run(), ASSERT_NOT_STR
@minh1302
#231 Edited constructor. Added test + Built Init(), setName(), getNam…
677eb3e 
…e().
Merge branch 'development' into java.lang.Thread
a8032c8
#231 Implement Semaphore, Thread::join()
0071038
#231 Fix test case
5bfec5b
#231 Test std::thread
57fcc87
#231 Remove semaphore
88d4bb7
@dquangit
Resolve conflict
dde64dd
#231 Add new Semaphore
b56cf71
#231 Try decreasing sleep time
358a395
#231 Comment join testcase
1f584a9
#231 Uncomment testcase, comment destructor
c51c8d4
#231 Comment testcase & destructor
ad7f32a
#231 Comment testcase
134302a
#231 Try fixing crash
44d93e4
#231 Try fixing crash
dc38f78
#231 Add class field init
60e84c1
#231 Uncomment thread::join() testcase
53f89ce
@sonda2208 sonda2208 self-assigned this Sep 18, 2017
@sonda2208 sonda2208 requested review from a user, dthongvl and loint September 18, 2017 17:05
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2017

Codecov Report

Merging #258 into development will increase coverage by 0.36%.
The diff coverage is 99.53%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #258      +/-   ##
===============================================
+ Coverage         95.2%   95.56%   +0.36%     
===============================================
  Files              169      172       +3     
  Lines            15057    16356    +1299     
  Branches           206      188      -18     
===============================================
+ Hits             14335    15631    +1296     
- Misses             722      725       +3
Impacted Files Coverage Δ
java/util/Concurrent/Semaphore/Semaphore.cpp 98.33% <ø> (ø) ⬆️
java/lang/Runnable/Runnable.hpp 100% <ø> (ø)
java/lang/Thread/ThreadTest.cpp 100% <100%> (ø)
kernel/string/convert.c 92.5% <100%> (+0.83%) ⬆️
java/lang/Float/Float.hpp 100% <100%> (ø) ⬆️
kernel/string/convert_test.c 100% <100%> (ø) ⬆️
java/lang/Double/DoubleTest.cpp 100% <100%> (ø) ⬆️
java/lang/Double/Double.hpp 100% <100%> (ø) ⬆️
java/lang/Float/FloatTest.cpp 100% <100%> (ø) ⬆️
kernel/test.h 55.12% <80%> (+0.62%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e6d05...53f89ce. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2017 •
edited
Loading

Codecov Report

Merging #258 into development will decrease coverage by 1.74%.
The diff coverage is 90.86%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #258      +/-   ##
===============================================
- Coverage           96%   94.25%   -1.75%     
===============================================
  Files              190      180      -10     
  Lines            16754    15592    -1162     
  Branches             0      268     +268     
===============================================
- Hits             16084    14696    -1388     
- Misses             670      896     +226
Impacted Files Coverage Δ
java/lang/Runnable/Runnable.hpp 100% <ø> (ø)
java/util/Concurrent/Semaphore/Semaphore.cpp 98.33% <ø> (ø) ⬆️
java/lang/String/String.cpp 95.62% <0%> (-3.08%) ⬇️
.../InterruptedException/InterruptedExceptionTest.cpp 100% <100%> (ø)
java/lang/Thread/ThreadTest.cpp 100% <100%> (ø)
...lang/InterruptedException/InterruptedException.hpp 100% <100%> (ø) ⬆️
...lang/InterruptedException/InterruptedException.cpp 100% <100%> (ø) ⬆️
java/lang/Thread/Thread.cpp 93.47% <93.47%> (ø)
java/lang/String/String.hpp 96.52% <98%> (+0.83%) ⬆️
java/util/Date/Date.cpp 0% <0%> (-100%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1f908...1cd6bc5. Read the comment docs.

@ghost ghost self-assigned this Sep 19, 2017
@ghost ghost added reviewing and removed pull request labels Sep 19, 2017
@loint loint changed the title Java.lang.thread Java.Lang.Thread Sep 19, 2017
sonda2208 and others added 23 commits September 25, 2017 21:19
#231 Add Thread::sleep()
3063d6b
#231 Implement Thread::getId(), Thread::currentThread(), InterruptedE…
7e2998b 
…xception
#231 Add print long long to String:format(), remove Thread::sleep() t…
536f0ec 
…est case
#231 Debug getting thread id in appveyor env
19d8ae4
#231 Change method get thread id
eda2316
@minh1302
#231 Fix conflict
eacd6d6
#231 Fix getting thread id
10e2604
#231 Fix getting thread id
e6d5b2f
#231 Fix getting thread id
51a3b9e
#231 Remove unused ostream
4ca1d95
@minh1302
#231 Fixed conflict
dfdefe2
#231 Try installing clang++
be8932b
Try installing clang++
3dd94e0
Try installing clang++
9a6db9f
Try installing clang++
a7cf885
Test brew
715385a
Test brew
bf111d3
Test brew
a675a45
#231 Try installing clang++
c4c4596
#231 Try installing clang++
7e6926f
#231 Try installing clang++
55af676
#231 Try installing clang++
d627740
#231 Try installing clang++
c1bae3e
@ghost ghost removed their assignment Dec 19, 2017
@tiny-express tiny-express merged commit 0e1da3c into development Mar 25, 2018
@loint loint deleted the java.lang.Thread branch April 13, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dthongvl dthongvl Awaiting requested review from dthongvl

@loint loint Awaiting requested review from loint

Assignees

@sonda2208 sonda2208

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sonda2208 @tiny-express @minh1302 @dquangit @loint