Added operators for Java::Lang::String and Array#286
Merged
tiny-express merged 38 commits intodevelopmentfrom Oct 20, 2017
Merged
Conversation
…&anotherHashMap)
…ll(BiFunction function)
…ue, Value&)> remappingFunction)
…on<void (Key , Value, Value&)> mappingFunction)
…tion<void (Key , Value, Value&)> mappingFunction)
…or code in Arrays.hpp using macro
Codecov Report
@@ Coverage Diff @@
## development #286 +/- ##
===============================================
+ Coverage 95.6% 95.61% +0.01%
===============================================
Files 186 186
Lines 16541 16565 +24
Branches 268 270 +2
===============================================
+ Hits 15814 15839 +25
+ Misses 727 726 -1
Continue to review full report at Codecov.
|
dthongvl
suggested changes
Oct 16, 2017
| } | ||
|
|
||
| // FIXME | ||
| // FIXME |
Contributor
There was a problem hiding this comment.
Please fix this or describe why you cant fix.
Author
There was a problem hiding this comment.
Yep, I just reformat code style, maybe you should ask the author of that method first.
java/util/Arrays/Arrays.hpp
Outdated
| } | ||
|
|
||
| template<typename T, typename U> | ||
| static Array<T> copyOf(Array<U> u, int newLength, T newType) { |
java/util/Arrays/Arrays.hpp
Outdated
| } | ||
|
|
||
| template<typename T> | ||
| static void fill0(Array<T> *a, int fromIndex, int toIndex, T val) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build operator [] (set, get) for java.util.Arrays
Example:
Array a = {1, 2, 4};
a[2] = 3;
assertEquals(3, a[2]);
build operator [] (set, get) java.lang.String
Example:
String a = "123";
a[2] = 3;
assertEquals('3', a[2]);
Reformat code Arrays.hpp, Object.hpp, String.cpp, String.hpp, StringTest.cpp
Refactor code Arrays.hpp using macro