Important: Bug fixes affecting tracking resolution + Shape of luminous region for resolution studies#405
Merged
alkemyst merged 11 commits intotkLayout:dev_gabiefrom Dec 8, 2017
Merged
Conversation
…e in the case of an inactive element crossing the Z=0 plane. 1) Should take the negative value of eta on the left side, otherwise comparisions with track eta does not make any sense!!! 2) Should be innerRadius + rWidth instead of innerRadius. Fortunately, was unused since all inactive surfaces are cut in 2 by the Z=0 plane.
…only for tracks coming from 0 until now).
…ctive element, one should not select the Z > 0 volumes only (assuming eta >= 0). Indeed, the IP can be at Z < 0, hence volumes on (-Z) side can be hit.
…unt in track length section calculation!
…red along a track!.
…ement::checkTrackHits has the following issues in devLite: some hits positions are wrongly computed and are actually not inside the inactive volume, hugely increasing the total crossed MB (and hence worsening the resolution). + Case of a tube or disk crossed in the non-trivial sense not always taken into account. Created new and fully debugged InactiveElement::checkTrackHits method (should be backported to devLitegit log).
Contributor
Author
|
Fully tested :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
Results (on OT613_200_IT404 geometry) :
The effects are significant on resolution (pixel), resolution (tracker) and resolution (trigger).
Example: Longitudinal impact parameter resolution vs. η (const Pt across η):
Before this PR:
After merging this PR:
NB: Details:
A detail of the impact of the fixes can be found here:
NB: TO DO list (coming in further PR):