Draft
Conversation
boost::ptr_vector requires a complete type, and not forward declarations
TBPX: - Fixed the Z mismatch caused by the wrong offset direction in Sensor.cc TEPX and TFPX: - Refactored Ring.cc: modules are assigned IDs with monotonically increasing phi - Fixed endcap module assignment logic: Use pre-computed information for DetId assignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add headers
boost::ptr_vectorrequires a completematerial::SupportStructuretype rather than forward declarations.Refactored
DetIdBuildertklayout -T -R -w geometries/CMS_Phase2/OT806_IT742.cfg --xmloutput matchesupstream/main.DetId mismatch for the L1 split-sensors
CMSSW modified its DetId schema to account for the reordering of the pixel + L1 split-sensors, causing tkLayout's pixel sensor DetId list to be 108 entries shorter than CMSSW's.
const Polygon3d<4>& Sensor::hitPoly() const.Coordinate mismatch
tkLayout's pixel sensor lists had non-negligible differences in Z ($\delta$ > 0.2 cm) and $\boldsymbol{\varphi}$ ($\delta$ > 1°) placement relative to the CMSSW's pixel sensors list.
Further analysis showed that for each CMSSW sensor, a corresponding tkLayout sensor existed in approximately the same position, indicating that the sensors were mislabeled rather than misplaced.
TBPX
L1 upper and lower sensors were inverted, causing a coordinate mismatch along the Z-axis.
Sensor.ccnow correctly applies the offset to split-sensors.TEPX and TFPX
phiRef_logic inEndcapDetIdBuilder::visit(EndcapModule& m)would fail for unevenly spaced modules, inverting the location of the odd and even subdisks for some rings/layers.Ring.cc: modules are assigned IDs with monotonically increasingEndcapDetIdBuilder::visit(EndcapModule&)now uses pre-computed information for the DetId assignment.Spanning over the entire list after the fix: