Correctly return finished#6
Open
facontidavide wants to merge 1 commit intotonbit:masterfrom
Open
Conversation
Owner
|
After co-routine is created, it will not start to run until thread owner resumes it. This behavior makes co-routine more flexible, splits object instantiating and routine running. |
Author
|
The PR doesn't affect the behavior when routine is created |
Owner
|
PR means ? |
Author
|
PR = Pull request :) What I mean, is that in the example I provided, the 4th resume would return 0, even if the end of the coroutine was reached. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I think this change makes the behavior of resume more semantically correct.
Consider the following code
I think it is reasonable to expect an output like
I would also suggest to add an enum like this
Cheers
Davide