Open
Conversation
juliagallucci
suggested changes
May 5, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Few issues with code. It only checks that all characters in msg1 exist in msg2 — but not whether counts match. So "aab" and "abz" would incorrectly return True.
Hint: Try simplifying using fewer lines with sorted() and string methods. Please revise
Owner
Author
|
Thnx @juliagallucci, let me work and update the changes |
Owner
Author
|
@juliagallucci |
Owner
Author
|
Thnx @juliagallucci for helping us out all through the courses!!! |
Owner
Author
|
Also, I am assuming like other assignments, we won't merge assignment1, this is considered as assignment submission and approved/pass as well? |
|
Yes thats correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anagram check assignment submitted