MB-9638: Add ecs deploy + codebuild config + nix updates#74
MB-9638: Add ecs deploy + codebuild config + nix updates#74ronaktruss merged 4 commits intomasterfrom
Conversation
| COPY locustfiles /app/locustfiles | ||
| COPY static /app/static | ||
| COPY tasks /app/tasks | ||
| COPY utils /app/utils |
There was a problem hiding this comment.
Is there a reason that the original line was replaced with this? When using docker to run tests locally with this change we get an error saying can't open file '/app/local_locust.py'. We may need add something like
COPY local_locust.py /app/local_locust.py
Both the old and new code work when running locust in AWS
There was a problem hiding this comment.
Is there a reason we need to run the load test inside docker locally? It has caused some complication/problems in the past
There was a problem hiding this comment.
Moving forward there shouldn't be as we would likely want all of the tests run in AWS. I mentioned the above because up until this PR local testing was the main method of testing. The setup docs provide instructions to support local testing through docker so thought we were going to keep supporting it.
If its caused some issues in the past and we aren't planning on using it moving forward I don't think this is something we need to address. We will likely want to update the docs to reflect this.
There was a problem hiding this comment.
Ah! Yeah, running in docker locally caused problems in the past, and so I think we'd like to not do that anymore. Perhaps that can be a follow up PR to cleanup/remove the documentation to make that clearer?
|
Outside of the above comment, everything else looks good to me! |
29aac83 to
4853997
Compare
Description
Provide a way to deploy to ECS
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
Code Review Verification Steps
References