rename --body to --release_notes, add --release_notes_file (see #155) by svenfuchs · Pull Request #1069 · travis-ci/dpl

svenfuchs · 2019-08-19T11:57:24Z

Can be tested using:

deploy:
  provider: releases
  edge:
    branch: sf-releases-release-notes
⋮

BanzaiMan · 2019-08-21T14:31:51Z

I think body is an Octokit/API-provided option that gets tied to Releases, so I am not a fan of removing this option.

svenfuchs · 2019-08-21T14:42:24Z

@BanzaiMan it doesn't remove it, but still keeps it as an alias (so people's deploy configs won't break)

but i'm not sure we have to stick with Octokit's nomenclature necessarily? body seems like a rather technical detail to me, and "release notes" is what they use in their documentation https://github.com/octokit/octokit.rb/blob/master/lib/octokit/client/releases.rb#L25 (which is where i've grabbed this name from)

i'm not set on release_notes, but i think it should be something that works well with a prefix _file ... i'd think body_file would be just too weird :)

BanzaiMan · 2019-08-21T14:45:17Z

OK. I have no other concerns.

Midnighter · 2019-09-01T15:19:20Z

@svenfuchs I tried to test it with the following demo repo https://github.com/Midnighter/travis-release-notes/ but my config is not recognized and doesn't trigger a job 😞

Does it only work for provider: pages? I thought most people in #155 wanted it for provider: releases.

Also doesn't help that there is no clear way to validate a configuration :/ but that's another issue.

svenfuchs · 2019-09-01T20:32:48Z

@Midnighter it seems your config has both a matrix and a jobs key. these are aliases, and matrix will take precedence, so jobs is silently ignored, unfortunately. i'd recommend moving fast_finish: true into the jobs section, and removing matrix.

Does it only work for provider: pages?

whoops, no, sorry. bad copy and paste, i've fixed that. these options are available on the releases provider https://github.com/travis-ci/dpl/blob/master/lib/dpl/providers/releases.rb#L28

Midnighter · 2019-09-02T06:53:22Z

Thanks for the hint! I got the deploy to run but now the file is not found and I don't get a lot of information from the log to try and fix it.

/home/travis/.rvm/gems/ruby-2.4.5/gems/cl-1.1.1/lib/cl/opts/validate.rb:32:in apply: Missing required option: file

https://travis-ci.org/Midnighter/travis-release-notes/jobs/579659390

svenfuchs · 2019-09-02T13:15:31Z

@Midnighter that's because the release provider expects you to specify a file option in your build config https://github.com/Midnighter/travis-release-notes/blob/c03b6281fc3cbdbc44a32ead08b31a6b27ae4a36/.travis.yml#L35 (see https://docs.travis-ci.com/user/deployment/releases/)

If you meant to upload all files then you can specify:

deploy:
  - provider: pages
     file: *
     file_glob: true

I have also opened #1093 that would switch this around a little, and make your current config behave the same. I think that would be slightly better UX, but I'm not yet sure if we want to merge that PR.

If you want to give it a try nonetheless, you can use:

deploy:
  - provider: pages
     edge:
       branch: sf-releases-file

On that branch file and file_glob would not be required any more, but default to the same behavior.

svenfuchs · 2019-09-02T13:16:16Z

Also curious that you are getting that noisy backtrace on your build log. That actually shouldn't be there.

Midnighter · 2019-09-02T13:32:49Z

Ah, thank you. I tried to create a minimal example but I'm forgetting the important bits 😉 Thanks for your help.

Midnighter · 2019-09-02T13:39:39Z

Works great! Thank you for the PR and your help here ❤️

See result https://github.com/Midnighter/travis-release-notes/releases

- See travis-ci/dpl#1069

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script - Add missing newline to build-windows.sh

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script - Add missing newline to build-windows.sh - Build x86 for Windows

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script - Add missing newline to build-windows.sh - Build x86 for Windows - Enable OpenMP in test builds

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script - Add missing newline to build-windows.sh - Build x86 for Windows - Enable OpenMP in test builds - Disable sanitizers on ubuntu test build - Disallow failures on snap build

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script - Add missing newline to build-windows.sh - Build x86 for Windows - Enable OpenMP in test builds - Enable sanitizers on macOS and Windows test builds - Disallow failures on snap build

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script - Add missing newline to build-windows.sh - Build x86 for Windows - Enable OpenMP in test builds - Enable sanitizers on macOS test build - Disallow failures on snap build

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script - Add missing newline to build-windows.sh - Build x86 for Windows - Enable OpenMP in test builds - Disable sanitizers on macOS test build - Disallow failures on snap build

MarkCallow · 2022-05-01T11:26:23Z

Does this work in dpl v1? I can't use dpl v2 due to #1213.

- Fix release notes by using edge deploy provider, see: travis-ci/dpl#1069 - Deploy only on master branch - Move to arm64-graviton2 - Rename debian -> ubuntu - Remove appveyor.yml - Remove redundant deploy stage in build step names - Get rid of bash code in files using sh, and explicitly use bash in sign-macos.sh script - Add missing newline to build-windows.sh - Build x86 for Windows - Enable OpenMP in test builds - Disable sanitizers on macOS test build - Disallow failures on snap build

rename --body to --release_notes, add --release_notes_file

d169c75

svenfuchs mentioned this pull request Aug 19, 2019

support github release :body #155

Closed

BanzaiMan approved these changes Aug 21, 2019

View reviewed changes

svenfuchs merged commit e26250b into master Aug 21, 2019

svenfuchs deleted the sf-releases-release-notes branch August 21, 2019 14:47

sdruskat mentioned this pull request Dec 15, 2019

Attach current section of CHANGELOG to body of release description hexatomic/hexatomic#90

Open

BrenekH mentioned this pull request Dec 16, 2019

Use github-changelog-generator for CHANGELOG.md BrenekH/kotlin-for-frc#16

Closed

vespakoen added a commit to vespakoen/solvespace that referenced this pull request Oct 22, 2020

Travis: fix release notes, add Windows OpenMP

d52d9b9

- See travis-ci/dpl#1069

vespakoen mentioned this pull request Oct 22, 2020

Travis: fix release notes, add Windows OpenMP solvespace/solvespace#766

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rename --body to --release_notes, add --release_notes_file (see #155)#1069

rename --body to --release_notes, add --release_notes_file (see #155)#1069
svenfuchs merged 1 commit intomasterfrom
sf-releases-release-notes

svenfuchs commented Aug 19, 2019 •

edited

Loading

Uh oh!

BanzaiMan commented Aug 21, 2019

Uh oh!

svenfuchs commented Aug 21, 2019

Uh oh!

BanzaiMan commented Aug 21, 2019

Uh oh!

Midnighter commented Sep 1, 2019

Uh oh!

svenfuchs commented Sep 1, 2019

Uh oh!

Midnighter commented Sep 2, 2019 •

edited

Loading

Uh oh!

svenfuchs commented Sep 2, 2019

Uh oh!

svenfuchs commented Sep 2, 2019

Uh oh!

Midnighter commented Sep 2, 2019

Uh oh!

Midnighter commented Sep 2, 2019

Uh oh!

MarkCallow commented May 1, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

svenfuchs commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BanzaiMan commented Aug 21, 2019

Uh oh!

svenfuchs commented Aug 21, 2019

Uh oh!

BanzaiMan commented Aug 21, 2019

Uh oh!

Midnighter commented Sep 1, 2019

Uh oh!

svenfuchs commented Sep 1, 2019

Uh oh!

Midnighter commented Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svenfuchs commented Sep 2, 2019

Uh oh!

svenfuchs commented Sep 2, 2019

Uh oh!

Midnighter commented Sep 2, 2019

Uh oh!

Midnighter commented Sep 2, 2019

Uh oh!

MarkCallow commented May 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

svenfuchs commented Aug 19, 2019 •

edited

Loading

Midnighter commented Sep 2, 2019 •

edited

Loading

MarkCallow commented May 1, 2022 •

edited

Loading