This repository was archived by the owner on Dec 11, 2023. It is now read-only.
goreleaser: generate completions from brew Formula#170
Merged
Conversation
tzununbekov
approved these changes
Dec 1, 2022
Member
tzununbekov
left a comment
There was a problem hiding this comment.
PRs with descriptions are easier to understand
fc354a1 to
a997aa7
Compare
a997aa7 to
b13283e
Compare
Contributor
Author
|
@tzununbekov please take another look. PR description has been added to describe the change |
tzununbekov
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since goreleaser is now used to generate the brew formula for
triggermesh/homebrew-cli/tmctl.rb, we need to ensure the generated formula also generates the shell completion. The support for writing brew stuff in goreleaser is pretty limited and I was unable to figure out how to install downloaded binary named (f.e)tmctl_macOS_amd64to be installed with the nametmctland then executetmctl completion....A workaround for this issue was to release tmctl as archives which contained the
tmctlbinary, making it possible to install the tmctl binary as-is. The install.sh script has also be updated to reflect this change.As a result of this PR, not only do we have completions generated properly as before, but also the download time would have been greatly reduced.