Skip to content
This repository was archived by the owner on Dec 11, 2023. It is now read-only.

tmctl delete command format update#318

Merged
tzununbekov merged 1 commit intomainfrom
cmd-delete-update
May 18, 2023
Merged

tmctl delete command format update#318
tzununbekov merged 1 commit intomainfrom
cmd-delete-update

Conversation

@tzununbekov
Copy link
Copy Markdown
Member

tmctl delete command, now being consistent with the create format, expects the component's kind and name args to execute the deletion, e.g.:

tmctl delete source foo
tmctl delete transformation bar
tmctl delete broker baz

etc.

@tzununbekov tzununbekov self-assigned this May 16, 2023
@tzununbekov
Copy link
Copy Markdown
Member Author

@jmcx I could use a second pair of eyes before merging this. Could you install from cmd-delete-update branch and run a quick check on the tmctl delete command?

@tzununbekov tzununbekov requested a review from jmcx May 16, 2023 10:56
@jmcx
Copy link
Copy Markdown

jmcx commented May 16, 2023

Works for me, and I really like this UX!

One thing we could (in the future perhaps) do is to prompt for confirmation when deleting the broker, especially when it has components attached, for those learning and that don't know that it will delete all related context. Not a new topic, already existed before.

In terms of release, this is a fairly disruptive change, but IMO we have more to gain from it in the future than we'll lose from it in terms of disruption, so I would go for it.

Copy link
Copy Markdown

@jmcx jmcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us know soon if this goes into 1.25 so we can make the change known in the blog and release notes. also will require some docs updates but I might not be able to do them in time, you might need to sync with Sameer tomorrow.

@tzununbekov tzununbekov merged commit 0c92756 into main May 18, 2023
@tzununbekov tzununbekov deleted the cmd-delete-update branch May 18, 2023 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants