Skip to content
This repository was archived by the owner on Dec 11, 2023. It is now read-only.

cleanup the wiretap container specific to the broker in case of tmctl stop#333

Merged
tzununbekov merged 1 commit intotriggermesh:mainfrom
NikhilSharmaWe:wiretapCleanup
Jun 15, 2023
Merged

cleanup the wiretap container specific to the broker in case of tmctl stop#333
tzununbekov merged 1 commit intotriggermesh:mainfrom
NikhilSharmaWe:wiretapCleanup

Conversation

@NikhilSharmaWe
Copy link
Copy Markdown
Contributor

@NikhilSharmaWe NikhilSharmaWe commented Jun 11, 2023

Description

This PR adds changes to clean up the wiretap container specific to a broker when tmctl stop is used to stop a broker container.

Motivation

Fixes: #205

@tzununbekov
Copy link
Copy Markdown
Member

tzununbekov commented Jun 12, 2023

Thank you, @NikhilSharmaWe! Do you think it is possible to also interrupt tmctl watch command that remains hanging after wiretap container removed? Leaving it active may create a wrong impression for users.

NikhilSharmaWe
NikhilSharmaWe commented Jun 12, 2023
View reviewed changes
@NikhilSharmaWe NikhilSharmaWe force-pushed the wiretapCleanup branch 2 times, most recently from f1137ca to 240853f Compare June 14, 2023 11:14
tzununbekov
tzununbekov approved these changes Jun 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@tzununbekov tzununbekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikhilSharmaWe could you run TMCTL_GENERATE_DOCS=true go run main.go and push the changes, there was a core version update so docs need to be updated.

@NikhilSharmaWe
Copy link
Copy Markdown
Contributor Author

NikhilSharmaWe commented Jun 14, 2023

@tzununbekov I have already tried running TMCTL_GENERATE_DOCS=true go run main.go for updating the docs but I am getting these error for multiple packages:

../../../pkg/mod/github.com/cloudevents/sdk-go/[email protected]/alias.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/docker/[email protected]+incompatible/errdefs/defs.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/apis/common/v1alpha1/aws_types.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/apis/extensions/v1alpha1/deepcopy_generated.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/apis/flow/v1alpha1/common_lifecycle.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/apis/sources/v1alpha1/awscloudwatch_lifecycle.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/apis/targets/v1alpha1/aws_comprehend_lifecycle.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/extensions/reconciler/function/adapter.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/flow/reconciler/jqtransformation/adapter.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/flow/reconciler/transformation/adapter.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/[email protected]/pkg/flow/reconciler/xmltojsontransformation/adapter.go:1:1: expected 'package', found 'EOF'

even after go get -u ./...

Should I update the docs manually?

@tzununbekov
Copy link
Copy Markdown
Member

tzununbekov commented Jun 14, 2023

That's weird, I just tested it on your branch and it worked fine. Yes, you can batch update it:

-      --version string   TriggerMesh components version. (default "v1.25.0")
+      --version string   TriggerMesh components version. (default "v1.25.1")

@NikhilSharmaWe NikhilSharmaWe force-pushed the wiretapCleanup branch 3 times, most recently from 2fbadb1 to a8bd3f0 Compare June 14, 2023 18:27
@NikhilSharmaWe
Copy link
Copy Markdown
Contributor Author

NikhilSharmaWe commented Jun 14, 2023 •
edited
Loading

Updated the docs

@tzununbekov tzununbekov merged commit 6f128a2 into triggermesh:main Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tzununbekov tzununbekov tzununbekov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tmctl stop should also stop the watch command

2 participants

@NikhilSharmaWe @tzununbekov