Skip to content

feat:Analytics and rebranding#10

Merged
Aman-Aalam merged 5 commits intomasterfrom
analytics-and-rebranding
Mar 8, 2023
Merged

feat:Analytics and rebranding#10
Aman-Aalam merged 5 commits intomasterfrom
analytics-and-rebranding

Conversation

@Aman-Aalam
Copy link
Copy Markdown
Contributor

Feature

Added Trolley-Source header in requests, added routeMinimum attribute, rebranded Payment Rails instances to Trolley wherever possible.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, create a GitHub Issue in this repository.

@Aman-Aalam Aman-Aalam force-pushed the analytics-and-rebranding branch from 03fc3dc to 5c6f69c Compare March 2, 2023 04:28
Copy link
Copy Markdown

@julie-trolley julie-trolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to set up the env and unit test all works fine.
I have no idea how to run the integrations tests, but all the fix is only change the brand name, looks good to me.

@Aman-Aalam Aman-Aalam merged commit 2c5d395 into master Mar 8, 2023
@Aman-Aalam Aman-Aalam deleted the analytics-and-rebranding branch May 3, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants