Closed
Conversation
3c8b2de to
b21955f
Compare
b21955f to
6844b5b
Compare
Contributor
Author
|
Can someone please setup travis to prove that the tests all pass against the latest uap-core? |
|
Any update on this merge? |
Contributor
Author
|
Some work in vain. 😢 I think its time to say good-bye dear PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables "brand-model" parsing according to the Specification.
Note: Tests will NOT pass unless ua-parser/uap-core#10 is merged.