Conversation
app.py
Outdated
Contributor
There was a problem hiding this comment.
are you sure we want to do this?
Contributor
Author
There was a problem hiding this comment.
Yes it needs to happen because of all the ssl stuff @ai did
Contributor
There was a problem hiding this comment.
do you mean me? all i did was fix the test by enabling debug mode. prior to that, literally every test was failing
Contributor
There was a problem hiding this comment.
also, i only enabled it for the test run, so it should not affect normal behavior
Contributor
|
These should probably be two separate pull requests. |
test/test_endpoints.py
Outdated
Contributor
There was a problem hiding this comment.
we should assert something about the body
kaushal
added a commit
that referenced
this pull request
Aug 22, 2014
Improve code coverage by including missing tests, and assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.