Conversation
New fields added to CMIS
| emaid = models.TextField(max_length=12, null=True) | ||
| dob = models.DateField(null=True, blank=True) | ||
| field1 = models.CharField(max_length=55, null=True) | ||
| field2 = models.CharField(max_length=55, null=True) |
There was a problem hiding this comment.
null=True not recommended to be used in CharField
| ema = models.CharField(max_length=1, null=True) | ||
| emaid = models.TextField(max_length=12, null=True) | ||
| dob = models.DateField(null=True, blank=True) | ||
| field1 = models.CharField(max_length=55, null=True) |
There was a problem hiding this comment.
null=True not recommended to be used in CharField
| emaid = models.TextField(max_length=12, null=True) | ||
| dob = models.DateField(null=True, blank=True) | ||
| field1 = models.CharField(max_length=55, null=True) | ||
| field2 = models.CharField(max_length=55, null=True) |
There was a problem hiding this comment.
null=True not recommended to be used in CharField
| ema = models.CharField(max_length=1, null=True) | ||
| emaid = models.TextField(max_length=12, null=True) | ||
| dob = models.DateField(null=True, blank=True) | ||
| field1 = models.CharField(max_length=55, null=True) |
There was a problem hiding this comment.
null=True not recommended to be used in CharField
| emaid = models.TextField(max_length=12, null=True) | ||
| dob = models.DateField(null=True) | ||
| field1 = models.CharField(max_length=55, null=True) | ||
| field2 = models.CharField(max_length=55, null=True) |
There was a problem hiding this comment.
null=True not recommended to be used in CharField
| ema = models.CharField(max_length=1, null=True) | ||
| emaid = models.TextField(max_length=12, null=True) | ||
| dob = models.DateField(null=True) | ||
| field1 = models.CharField(max_length=55, null=True) |
There was a problem hiding this comment.
null=True not recommended to be used in CharField
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4239 +/- ##
==========================================
+ Coverage 80.46% 80.48% +0.02%
==========================================
Files 151 151
Lines 8615 8620 +5
==========================================
+ Hits 6932 6938 +6
+ Misses 1683 1682 -1 |
New fields added to CMIS
What does this PR do?
For example: Changes the way we retrieve bookings
✅ Pull Request checklist
🚨 Is this a breaking change for API clients?
Yes/No
🚀 Deploy notes
For example: Need to run migrations as part of deployment
Anything else