Skip to content

Fix JSONB expected value in the ARU#982

Merged
lucacug merged 1 commit intohotfix/1.14.1from
hotfix/ticket-269/aru-upload-bug
Jun 11, 2024
Merged

Fix JSONB expected value in the ARU#982
lucacug merged 1 commit intohotfix/1.14.1from
hotfix/ticket-269/aru-upload-bug

Conversation

@lucacug
Copy link
Copy Markdown
Contributor

@lucacug lucacug commented Jun 10, 2024

Some column values in the csv can be empty. This fix puts those values in the JSONB field as empty strings rather than nil.

After fixing one of the errors, the refresh_errors_if_needed method will go through all the errors again and check the one resolved to remove them from the list.

Running down the list of errors, the code searches for the matching_criteria JSONB field to find the existing errors; that is where the mismatch was happening, with the record in the db having nil and the matching value expecting an empty string, so trying to create a new error_record rather than update the preexisting one.

Happy to have a chat if any of the above is not clear

@lucacug lucacug requested a review from pdl June 10, 2024 10:41
@lucacug lucacug changed the base branch from master to hotfix/1.14.1 June 11, 2024 12:58
@lucacug lucacug merged commit dcf377b into hotfix/1.14.1 Jun 11, 2024
@lucacug lucacug deleted the hotfix/ticket-269/aru-upload-bug branch June 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant