Skip to content

fix(ci): stop push runs from preferring stale mainnet secret#432

Merged
ErikBjare merged 1 commit intouniswap-python:dev/v4-finfrom
TimeToBuildBob:fix/ci-ignore-stale-mainnet-secret
Mar 27, 2026
Merged

fix(ci): stop push runs from preferring stale mainnet secret#432
ErikBjare merged 1 commit intouniswap-python:dev/v4-finfrom
TimeToBuildBob:fix/ci-ignore-stale-mainnet-secret

Conversation

@TimeToBuildBob
Copy link
Copy Markdown

Summary

  • stop the test workflow from preferring secrets.MAINNET_PROVIDER
  • always use https://ethereum.publicnode.com for mainnet CI forks

Why

PR #431 fixed the fallback URL, but the post-merge push run on dev/v4-fin still consumed the repo secret on push jobs. That secret is a stale Infura URL, so Ganache still failed with Too Many Requests.

Evidence:

  • PR run for fix(ci): replace rate-limited Infura with public RPC #431 used PROVIDER_MAINNET: https://ethereum.publicnode.com and passed the mainnet jobs
  • post-merge push run for commit b2eb3a0 showed PROVIDER_MAINNET: *** and failed with Invalid response from fork provider: {"code":-32005,"message":"Too Many Requests"...see https://infura.io/dashboard}

This makes push CI behave differently from the PR run, which is dumb. CI should use the known-good public endpoint directly until the secret is updated or removed.

Notes

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 26, 2026

Greptile Summary

Reviewed PR #432 which fixes CI by hardcoding https://ethereum.publicnode.com as PROVIDER_MAINNET instead of using the secrets.MAINNET_PROVIDER || fallback expression that was silently consuming a stale Infura secret on push runs.

Confidence Score: 5/5

Safe to merge — the one-line change is targeted, low-risk, and directly addresses the confirmed CI regression.

The diff is a single-line replacement that removes a secret reference in favour of a hardcoded public URL. The logic is straightforward, the root cause is well-evidenced in the PR description, and the only remaining item (stale comment on line 79) is a non-blocking style nit.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/test.yml Removes the `secrets.MAINNET_PROVIDER

Comments Outside Diff (1)

  1. .github/workflows/test.yml, line 79 (link)

    P2 Stale comment no longer reflects reality

    This comment was accurate when PROVIDER_MAINNET used the secrets.MAINNET_PROVIDER || fallback expression, but now that the secret is bypassed entirely the comment is misleading. Consider updating it to reflect the new intent.

Reviews (1): Last reviewed commit: "fix(ci): ignore stale mainnet secret in ..." | Re-trigger Greptile

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dev/v4-fin@b2eb3a0). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev/v4-fin     #432   +/-   ##
=============================================
  Coverage              ?   58.83%           
=============================================
  Files                 ?       12           
  Lines                 ?     1834           
  Branches              ?        0           
=============================================
  Hits                  ?     1079           
  Misses                ?      755           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TimeToBuildBob
Copy link
Copy Markdown
Author

Confirmed the mainnet regression is fixed here.

  • PR run 23620730825 now uses PROVIDER_MAINNET: https://ethereum.publicnode.com, and test (v1, mainnet), test (v2, mainnet), and test (v3, mainnet) all pass.
  • The only remaining red check is test (v3, arbitrum), and it is the same broader failure we already saw on dev/v4-fin after fix(ci): replace rate-limited Infura with public RPC #431 (23619459609 on 2026-03-26): the forked trade setup in tests/test_uniswap.py is reverting on Arbitrum (test_assets / test_make_trade*).

I am not broadening this PR to paper over that unrelated Arbitrum failure. This PR does the narrow thing it was opened for: stop push runs from preferring the stale mainnet secret.

@ErikBjare ErikBjare merged commit ade1cf8 into uniswap-python:dev/v4-fin Mar 27, 2026
4 of 5 checks passed
@TimeToBuildBob
Copy link
Copy Markdown
Author

Addressed Greptile's P2 nit (3f73505): updated stale comment on line 79 to reflect that all provider env vars are now hardcoded public endpoints (no longer "use secret if available").

Everything else is unchanged — Greptile 5/5, mainnet CI green, Arbitrum failure is pre-existing and unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants