fix: share internal boot state across onboarding by elibosley · Pull Request #1920 · unraid/api

elibosley · 2026-03-16T14:31:26Z

Summary

extract a shared internal boot state service that uses the same backend detection as the notification flow
expose that state through vars and use it to hide/block onboarding internal boot setup when the system is still booted from flash but internal boot is already configured
keep registration aligned with the same state while preserving the existing client-side fallback

Validation

pnpm lint in api/
pnpm type-check in api/
pnpm lint in web/
pnpm type-check in web/
targeted vitest coverage for onboarding, vars, notification, and registration flows

Summary by CodeRabbit

New Features
- Detects if the system is booted from flash with internal boot already configured and surfaces this state.
- Onboarding blocks re-configuration when internal boot is already enabled.
Improvements
- Boot state is tracked and exposed across the UI and API for more accurate UI decisions.
- Onboarding step visibility and the boot transfer button logic have been tightened and simplified.

coderabbitai · 2026-03-16T14:31:45Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 79db950d-7762-4a62-b5a7-13cd0479c7a7

📥 Commits

Reviewing files that changed from the base of the PR and between c9abf6f and 560da92.

📒 Files selected for processing (6)

api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.ts
api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.ts
api/src/unraid-api/graph/resolvers/vars/vars.resolver.spec.ts
api/src/unraid-api/graph/resolvers/vars/vars.resolver.ts
web/__test__/store/server.test.ts
web/src/store/server.ts

Disabled knowledge base sources:

Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

Walkthrough

Adds a new boolean Vars field bootedFromFlashWithInternalBootSetup, a backend InternalBootStateService to determine that state (uses ArrayService + DisksService), updates onboarding and notification flows to respect it, and surfaces the field through GraphQL to frontend UI and store logic which hide/disable internal-boot configuration when appropriate.

Changes

Cohort / File(s)	Summary
GraphQL Schema `api/generated-schema.graphql`	Added `bootedFromFlashWithInternalBootSetup: Boolean` to `Vars`.
Internal boot state service & module `api/src/unraid-api/graph/resolvers/disks/internal-boot-state.service.ts`, `api/src/unraid-api/graph/resolvers/disks/disks.module.ts`	New `InternalBootStateService` (depends on `ArrayService`, `DisksService`) with methods to determine boot-from-flash + internal-boot setup; exported from `DisksModule`.
Notification service updates `api/src/unraid-api/graph/resolvers/disks/internal-boot-notification.service.ts`, `api/src/unraid-api/graph/resolvers/disks/internal-boot-notification.service.spec.ts`	Replaced `DisksService` usage with `InternalBootStateService` and updated method calls and tests to the new boolean-check API.
Onboarding changes & tests `api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.ts`, `api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.ts`	Injected `InternalBootStateService` into onboarding service; short-circuits internal-boot pool creation when already configured; tests updated/added to cover that path.
Vars resolver & model `api/src/unraid-api/graph/resolvers/vars/vars.model.ts`, `api/src/unraid-api/graph/resolvers/vars/vars.resolver.ts`, `api/src/unraid-api/graph/resolvers/vars/vars.resolver.spec.ts`	Added optional field to `Vars` model; `VarsResolver` now fetches boot state via `InternalBootStateService` (with try/catch) and includes it in responses; tests adjusted to mock service and log on lookup failure.
Frontend GraphQL & types `web/src/composables/gql/graphql.ts`, `web/src/composables/gql/gql.ts`, `web/src/store/server.fragment.ts`	Extended client GraphQL types and document literals to include `bootedFromFlashWithInternalBootSetup` in `Vars` for relevant queries (GetInternalBootContext, GetInternalBootStepVisibility, ServerState).
Frontend store & types `web/src/store/server.ts`, `web/types/server.ts`, `web/__test__/store/server.test.ts`	Added `bootedFromFlashWithInternalBootSetup` to Server type and store; internal ref `reportedBootedFromFlashWithInternalBootSetup` and computed with fallback implemented; hydration and tests updated.
Frontend UI & tests `web/src/components/Onboarding/OnboardingModal.vue`, `web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue`, `web/src/components/Registration.standalone.vue`, `web/src/components/Onboarding/graphql/`, `web/__test__/components/Onboarding/`	UI now hides/disables internal-boot configuration when flag is true; eligibility logic updated; queries and tests adapted to pass/expect `bootedFromFlashWithInternalBootSetup` (tests for true/false/null cases added/modified).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant UI as "UI / Client"
  participant Resolver as "VarsResolver"
  participant Service as "InternalBootStateService"
  participant Array as "ArrayService"
  participant Disks as "DisksService"

  UI->>Resolver: query vars
  Resolver->>Service: getBootedFromFlashWithInternalBootSetup()
  Service->>Array: getArray() / read boot disk
  Array-->>Service: bootDisk info
  Service->>Disks: getInternalBootDevices(bootDisk) (if FLASH)
  Disks-->>Service: devices[]
  Service-->>Resolver: boolean bootedFromFlashWithInternalBootSetup
  Resolver-->>UI: vars { ..., bootedFromFlashWithInternalBootSetup }
  UI->>UI: hide/disable internal-boot step (if true)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Poem

🐰 I sniff the flash, a secret found,
A tiny flag that keeps steps down,
We guard the pool, we skip the dance,
A quiet hop avoids mischance. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: extracting and sharing internal boot state detection logic across onboarding flows and notification systems.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch codex/share-internal-boot-state

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9abf6f218

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-16T14:36:51Z

api/src/unraid-api/graph/resolvers/vars/vars.resolver.ts

+        const bootedFromFlashWithInternalBootSetup =
+            await this.internalBootStateService.getBootedFromFlashWithInternalBootSetup();


Handle internal-boot probe failures in vars resolver

vars() now blocks on internalBootStateService.getBootedFromFlashWithInternalBootSetup(), but this probe can throw (it reaches DisksService.getInternalBootDevices(), which calls disk discovery methods that are not guarded for all failures). Because there is no try/catch or fallback here, a transient disk-inspection error will fail the entire vars query (and serverState queries that include vars) instead of returning the existing vars payload.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-16T14:36:51Z

api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.ts

            };
        }

+        if (await this.isBootedFromFlashWithInternalBootSetup()) {


Keep preflight boot-state check inside mutation error path

The new isBootedFromFlashWithInternalBootSetup() check runs before the method’s try/catch, so if internal-boot state lookup throws (for example while reading array/disk state), createInternalBootPool() rejects with a GraphQL error instead of returning the structured OnboardingInternalBootResult failure response this mutation otherwise guarantees.

Useful? React with 👍 / 👎.

codecov · 2026-03-16T14:38:43Z

Codecov Report

❌ Patch coverage is 85.26316% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.04%. Comparing base (2daceab) to head (560da92).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...aph/resolvers/disks/internal-boot-state.service.ts	52.17%	11 Missing ⚠️
.../src/unraid-api/graph/resolvers/vars/vars.model.ts	0.00%	2 Missing ⚠️
web/src/store/server.ts	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
+ Coverage   50.99%   51.04%   +0.05%     
==========================================
  Files        1024     1025       +1     
  Lines       70569    70640      +71     
  Branches     7717     7738      +21     
==========================================
+ Hits        35985    36061      +76     
+ Misses      34458    34453       -5     
  Partials      126      126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.ts`:
- Around line 243-247: The test is asserting the full error string which couples
it to wording; instead assert behavior and a meaningful substring: keep checking
result for ok: false and code: 3 (e.g., via toMatchObject or separate expects
against result) and replace the exact-string check on result.output with a
substring assertion (e.g., expect(result.output).toContain('boot is already
configured') or 'internal boot'), referencing the test variable result in
onboarding-internal-boot.service.spec.ts.

In
`@api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.ts`:
- Around line 351-357: The current pre-check calls
this.isBootedFromFlashWithInternalBootSetup() outside the surrounding try/catch
so any error from that lookup can escape and crash the mutation; move the
boot-state lookup into the guarded path by invoking
this.isBootedFromFlashWithInternalBootSetup() inside the existing try/catch (or
wrap it in its own try/catch) and return the same { ok:false, code:3, output:...
} response on a successful check while ensuring any thrown error is caught and
handled by the function's error handling.

In `@api/src/unraid-api/graph/resolvers/vars/vars.resolver.ts`:
- Around line 24-30: The vars() resolver currently awaits
internalBootStateService.getBootedFromFlashWithInternalBootSetup() which can
throw and cause the whole vars query to fail; wrap that call in a try/catch
inside vars() and on error set a safe default (e.g., null or false) for
bootedFromFlashWithInternalBootSetup and optionally log the error, then continue
returning the merged object (id: 'vars', ...(getters.emhttp().var ?? {}),
bootedFromFlashWithInternalBootSetup) so failures in internalBootStateService do
not surface as fatal resolver errors.

In `@web/src/store/server.ts`:
- Around line 1072-1074: The current guard using "typeof
data?.bootedFromFlashWithInternalBootSetup !== 'undefined'" prevents clearing
stale reportedBootedFromFlashWithInternalBootSetup values; change the check to
use "'bootedFromFlashWithInternalBootSetup' in data" and when that property
exists assign reportedBootedFromFlashWithInternalBootSetup.value =
data.bootedFromFlashWithInternalBootSetup so the value can be set to
undefined/false by mutateServerStateFromApi mapping; update the code around the
existing reportedBootedFromFlashWithInternalBootSetup assignment in server.ts
accordingly.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a76466e7-5467-4496-b5a1-3e9733144beb

📥 Commits

Reviewing files that changed from the base of the PR and between 2daceab and c9abf6f.

📒 Files selected for processing (22)

api/generated-schema.graphql
api/src/unraid-api/graph/resolvers/disks/disks.module.ts
api/src/unraid-api/graph/resolvers/disks/internal-boot-notification.service.spec.ts
api/src/unraid-api/graph/resolvers/disks/internal-boot-notification.service.ts
api/src/unraid-api/graph/resolvers/disks/internal-boot-state.service.ts
api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.ts
api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.ts
api/src/unraid-api/graph/resolvers/vars/vars.model.ts
api/src/unraid-api/graph/resolvers/vars/vars.resolver.spec.ts
api/src/unraid-api/graph/resolvers/vars/vars.resolver.ts
web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts
web/__test__/components/Onboarding/OnboardingModal.test.ts
web/src/components/Onboarding/OnboardingModal.vue
web/src/components/Onboarding/graphql/getInternalBootContext.query.ts
web/src/components/Onboarding/graphql/getInternalBootStepVisibility.query.ts
web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue
web/src/components/Registration.standalone.vue
web/src/composables/gql/gql.ts
web/src/composables/gql/graphql.ts
web/src/store/server.fragment.ts
web/src/store/server.ts
web/types/server.ts

api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.ts

api/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.ts

api/src/unraid-api/graph/resolvers/vars/vars.resolver.ts

web/src/store/server.ts

elibosley · 2026-03-16T15:04:32Z

@coderabbitai review

coderabbitai · 2026-03-16T15:05:17Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

github-actions · 2026-03-16T15:12:51Z

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1920/dynamix.unraid.net.plg

@MitchellThompkins

🤖 I have created a release *beep* *boop* --- ## [4.30.0](v4.29.2...v4.30.0) (2026-03-18) ### Features * add internal boot step to onboarding flow ([#1881](#1881)) ([337aecc](337aecc)) * Add TPM licensing availability to registration ([#1908](#1908)) ([aa162eb](aa162eb)) * add UPS power ([#1874](#1874)) ([b531aed](b531aed)) * **api:** alert when usb boot has internal boot target ([#1898](#1898)) ([b94df47](b94df47)) * **api:** expose internal boot devices in array GraphQL ([#1894](#1894)) ([0736709](0736709)) * docker overview ([#1855](#1855)) ([9ef1cf1](9ef1cf1)) * **docker:** add update actions to container context menu ([#1867](#1867)) ([4ca3e06](4ca3e06)) * **docker:** disable containers page file modification ([#1870](#1870)) ([aaa0372](aaa0372)) * issues/1597: Temperature Monitoring - Thanks @MitchellThompkins ([a1be458](a1be458)) * New Crowdin updates ([#1809](#1809)) ([a7b3f07](a7b3f07)) * New Crowdin updates ([#1883](#1883)) ([14a8fa8](14a8fa8)) * **onboarding:** add new onboarding flows for Unraid OS ([#1746](#1746)) ([15bd747](15bd747)) * registration and trial actions use Account app ([#1928](#1928)) ([c2c0425](c2c0425)) * share internal boot state ([#1921](#1921)) ([8e4d44d](8e4d44d)) * **web:** show TPM move control for trial licenses ([#1911](#1911)) ([d00fb63](d00fb63)) ### Bug Fixes * Add dedicated TPM license move option ([#1909](#1909)) ([36c56f7](36c56f7)) * allow free USB targets in onboarding internal boot setup ([#1903](#1903)) ([298da54](298da54)) * API key key display truncation ([#1890](#1890)) ([b12f75c](b12f75c)) * **api:** harden PHP wrapper args for newer PHP versions ([#1901](#1901)) ([849f177](849f177)) * **api:** prevent flash notification startup fd exhaustion ([#1893](#1893)) ([4b231ad](4b231ad)) * clear stale onboarding modal session state ([#1904](#1904)) ([23f7836](23f7836)) * consistently clear onboarding draft ([#1916](#1916)) ([199d803](199d803)) * correct graphql-api.log timestamp formatting ([#1918](#1918)) ([243c5a8](243c5a8)) * **deps:** pin dependencies ([#1878](#1878)) ([db88eb8](db88eb8)) * **docker:** change "visit" to "webui" & use correct link ([#1863](#1863)) ([cab0880](cab0880)) * **docker:** improve start/stop UX with visual feedback ([#1865](#1865)) ([c084e25](c084e25)) * **docker:** remove aggressive caching to ensure data correctness ([#1864](#1864)) ([1c1bae8](1c1bae8)) * **docker:** sync template mappings in organizer to prevent false orphan warnings ([#1866](#1866)) ([38a6f0c](38a6f0c)) * onboarding internal-boot warning panel contrast and semantics ([#1927](#1927)) ([bb6f241](bb6f241)) * **onboarding:** add explicit EFI loader path for flash entry ([#1926](#1926)) ([429b438](429b438)) * **onboarding:** extend onboarding refresh timeout ([#1925](#1925)) ([e2a5f44](e2a5f44)) * **onboarding:** persist installed plugins in summary ([#1915](#1915)) ([07f4ebd](07f4ebd)) * **onboarding:** refine storage boot setup UX ([#1900](#1900)) ([1108d0a](1108d0a)) * polish onboarding flow ([#1902](#1902)) ([8742cac](8742cac)) * preserve registration device limits after refresh ([#1905](#1905)) ([234bfc7](234bfc7)) * prevent onboarding on API errors ([#1917](#1917)) ([540d6f9](540d6f9)) * remap TPM guid prefix to 01 ([#1924](#1924)) ([5360b5b](5360b5b)) * Return null for corrupted/invalid API key files and add Connect fixtures test ([#1886](#1886)) ([013e6c5](013e6c5)) * share internal boot state across onboarding ([#1920](#1920)) ([f9b293f](f9b293f)) * too many file descriptors with thousands of notifications ([#1887](#1887)) ([7956987](7956987)) * Treat onboarding patch updates as completed ([#1884](#1884)) ([d03b25e](d03b25e)) * unify onboarding internal boot state refresh ([#1923](#1923)) ([d3032c1](d3032c1)) * **web:** refresh internal boot onboarding state ([#1913](#1913)) ([1ca2129](1ca2129)) * **web:** stop showing callback errors after successful key installs ([#1892](#1892)) ([45f1402](45f1402)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Share internal boot state across onboarding and notifications

c9abf6f

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

coderabbitai bot requested changes Mar 16, 2026

View reviewed changes

Address CodeRabbit review feedback

560da92

elibosley changed the title ~~Share internal boot state across onboarding and notifications~~ fix: share internal boot state across onboarding Mar 16, 2026

elibosley merged commit f9b293f into main Mar 16, 2026
12 checks passed

elibosley deleted the codex/share-internal-boot-state branch March 16, 2026 15:13

github-actions bot mentioned this pull request Mar 16, 2026

chore(main): release 4.30.0 #1858

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: share internal boot state across onboarding#1920

fix: share internal boot state across onboarding#1920
elibosley merged 2 commits intomainfrom
codex/share-internal-boot-state

elibosley commented Mar 16, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 16, 2026 •

edited

Loading

Review failed

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot Mar 16, 2026

Uh oh!

codecov bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elibosley commented Mar 16, 2026

Uh oh!

coderabbitai bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		const bootedFromFlashWithInternalBootSetup =
		await this.internalBootStateService.getBootedFromFlashWithInternalBootSetup();

Conversation

elibosley commented Mar 16, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elibosley commented Mar 16, 2026

Uh oh!

coderabbitai bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

elibosley commented Mar 16, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 16, 2026 •

edited

Loading

codecov bot commented Mar 16, 2026 •

edited

Loading