web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts (1)

64-85: Mock emits string values while component may expect numbers.

The native <select> always emits string values via $event.target.value. For slotCountItems which uses numeric values (e.g., value: 1), the mock will emit "1" instead of 1. The handleSlotCountChange handler already handles this conversion, so tests will pass, but be aware of this type coercion behavior.

Additionally, the mock assumes all items are objects with item.value. Per SelectItemType definition, items can be primitives. Consider adding robustness for future-proofing:

♻️ Optional: Handle primitive items in mock

   Select: {
     props: ['modelValue', 'items', 'disabled', 'placeholder'],
     emits: ['update:modelValue'],
     template: `
       <select
         data-testid="select"
         :disabled="disabled"
         :value="modelValue ?? ''"
         `@change`="$emit('update:modelValue', $event.target.value)"
       >
         <option v-if="placeholder" value="">{{ placeholder }}</option>
         <option
           v-for="item in items"
-          :key="item.value"
-          :value="item.value"
-          :disabled="item.disabled"
+          :key="typeof item === 'object' ? item.value : item"
+          :value="typeof item === 'object' ? item.value : item"
+          :disabled="typeof item === 'object' ? item.disabled : false"
         >
-          {{ item.label }}
+          {{ typeof item === 'object' ? item.label : item }}
         </option>
       </select>
     `,
   },

Based on learnings: "Stub complex child components that aren't the focus of the test" - the current mock is sufficient for the component's usage patterns.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts` around
lines 64 - 85, The Select mock emits string values from $event.target.value
which can misrepresent numeric item values used by slotCountItems and consumed
by handleSlotCountChange; update the Select mock (component name Select) to emit
a parsed value (e.g., coerce numeric-looking strings back to numbers before
emitting to 'update:modelValue') and make the item iteration resilient to
primitive items by using item.value ?? item when reading the option value/label
so the mock supports both object and primitive SelectItemType shapes.

web/src/components/Onboarding/steps/OnboardingCoreSettingsStep.vue (1)

359-360: Consider extracting duplicated styling constant to a shared location.

This onboardingSelectClasses constant is identically defined in OnboardingInternalBootStep.vue (lines 558-560). Extracting it to a shared module (e.g., onboarding/constants.ts or a composable) would prevent future divergence if the styling needs adjustment.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/src/components/Onboarding/steps/OnboardingCoreSettingsStep.vue` around
lines 359 - 360, The duplicated CSS class string assigned to
onboardingSelectClasses (found in OnboardingCoreSettingsStep.vue and identically
in OnboardingInternalBootStep.vue) should be extracted to a shared
constant/export so both components import the same value; create a new module
(e.g., onboarding/constants.ts or a composable) that exports a named constant
like ONBOARDING_SELECT_CLASSES, replace the inline onboardingSelectClasses
declarations in both components with an import of that constant, and update
usages to reference the imported symbol to prevent future drift.

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".