Open
Conversation
src/main/java/Item.java
Outdated
Comment on lines
+2
to
+3
| String name; | ||
| double price; |
There was a problem hiding this comment.
Публичные поля лучше пометить final, чтобы исключить возможность модификации их извне
src/main/java/Main.java
Outdated
Comment on lines
+12
to
+20
| System.out.println("Введите название товара:"); | ||
| String itemName = scanner.next(); | ||
| myBuscket.addItem(itemName, getItemPrice()); | ||
| System.out.println("Товар добавлен."); | ||
|
|
||
| System.out.println("Вы хотите добавить еще товар? (введите любое слово чтобы продолжть или введите 'Завершить' чтобы закончить."); | ||
| if (scanner.next().equalsIgnoreCase("Завершить")) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Захардкоженные строчки лучше выносить в константы, чтобы уменьшить количество объектов, создаваемых в цикле
src/main/java/Main.java
Outdated
| myBuscket.CountPayments(); | ||
| } | ||
|
|
||
| static int GetPayersCount() { |
There was a problem hiding this comment.
Функции в джава принято называть с маленькой буквы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.