SR Validmind2 - First draft Validmind-226 Docs Update UM#167
Merged
Conversation
|
|
nrichers
requested changes
Apr 9, 2024
Collaborator
nrichers
left a comment
There was a problem hiding this comment.
Hi @subatraSR2, thank you for this PR. I left some comments that should be addressed. These comments mainly cover differences between the UI and what's described in your docs. I tested on https://app.dev.vm.validmind.ai/settings/organization if you want to check for yourself.
Co-authored-by: Nik Richers <[email protected]>
Co-authored-by: Nik Richers <[email protected]>
This has been updated to resolve comments from @nrichers
Co-authored-by: Nik Richers <[email protected]>
Co-authored-by: Nik Richers <[email protected]>
Co-authored-by: Nik Richers <[email protected]>
Co-authored-by: Nik Richers <[email protected]>
nrichers
approved these changes
May 17, 2024
Collaborator
nrichers
left a comment
There was a problem hiding this comment.
Re-reviewed and tested updated instructions — LGTM. 🎉🎉🎉
I made some very minor suggested changes to match UI labels which I can commit directly for you. Will also address any merge conflicts and get this PR merged.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
Working with Nik to help review this. Changed 2 files , manage-users & manage-groups
Note:
Groups - applies to both user and groups pages. Roles is still minimal, so no own page.
Manage users doc:
Manage groups doc
External Release Notes