Conversation
nrichers
approved these changes
Apr 30, 2024
Collaborator
There was a problem hiding this comment.
LGTM — looks GREAT to me! 🚢
I pushed 3337c9f to fix a broken notebook link, I hope that is OK.
(The broken link is the effect of some post-processing which, you guessed it, was broken. I fixed the link along with the post-processing.)
Collaborator
Author
Yay, thank you!
That explains why I couldn't figure out how to locate it. Can you put it on the list to tell me about this magical post-processing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
make get-source(& changed the Makefile back to clone frommain)quarto renderand spot checked the static site as well as adjusted some broken links that surfaced as a result of the new replacement notebook"Run dataset based tests" notebook
This notebook has been added under its own folder (
Run Tests) in the MODEL TESTING sectionAdjusted "Developer Framework" landing page
Added "Run dataset based tests" to MODEL TESTING section
Replicated the adjustments to the cards as in the above section
Fixed some broken links
There were some broken links as a result of replacing the two notebooks with the new one, so I modified the following releases (just hid those sections):
There was also a broken link in
integrate_external_test_providers.ipynbfor "implementing_custom_tests.ipynb" which should actually be:implement_custom_tests.ipynb(I've fixed them!)