Conversation
…-closed-beta-form
validbeck
approved these changes
May 8, 2024
Collaborator
validbeck
left a comment
There was a problem hiding this comment.
- I experienced some odd issues trying to review this PR (potentially user error 😓), but I more or less got the preview working! It looks like there are some conflicting files which may be the cause of the
Diverging branches can't be fast-forwardederror I got. - It also notably flagged
CONFLICT (content): Merge conflict in site/_site/search.jsoneven when I managed to resolve the previous error; presumably this is related to the fixing conflicts conversation. (Pointing this one out as it also told me "WARN: Unable to read search index - it may be corrupt. Please re-render the entire site to create a valid search index." and indeed the search no longer works in the preview...)- Can we maybe book a session I can record to go over conflicts and merging?
Otherwise, it looks good!
Collaborator
Author
Thank you for reviewing, @validbeck! Yes, we should do a session on merge conflicts and include @noosheenv in that. Let's maybe do that when you have a PR of your own with some merge conflicts? That way, it'll be more realistic. |
…-closed-beta-form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
With us winding down the closed beta program, we need to remove the signup from the docs site.
This PR:
No release notes for this — we plan to provide a final beta update and offer folks some swag as thanks.
External Release Notes