Conversation
|
|
sc-4370/release-notes-update
|
For the initial folks I tagged for review: I realized after I requested review that I had not updated the title — this release notes PR is READY FOR REVIEW. |
validbeck
left a comment
There was a problem hiding this comment.
I pulled this down and made committed some quick changes:
- Swapped references to product names with their variables
- MInor wording adjustments
- Some structural edits, like call-outs for the "Try it" invitations, more line breaks for readability, etc.
See attached PDF for preview:
Release Notes – May 22, 2024.pdf
Thank you for making these changes! You marked this as "changes requested" but what do you want me to update, @validbeck? Your comment doesn't say.
There's definitely something here — plain links are a bit understated — but I am on the fence about the current formatting with callouts, for the following reasons:
Let's chat about what the best approach is here. We already use buttons for some links and could try the same here, or we could look into inventing an entirely new convention for just this purpose. |
Just the suggestions I committed, and I hear you about the call-outs but I wanted to visually distinguish those links somehow as the previous formatting of them they were sort of lost. I like the idea of buttons for future endeavours, let's remember to chat about that! |
Are you able to live with leaving the call-outs for this round, unless you want to go back and manually change them as I adjusted some other visuals as well (so you can't just roll the commit back cleanly)? |
I'm doing some spit & polish right now and don't mind manually updating the callouts as there's not that many of them. But lemme run the updated version by you later today and then also by Robin. |
|
I have some comments regarding PR 185 the updated release notes, but which don't rise to the level of PR feedback... (I did add also some minor feedback into the actual PR, though.) In general, I found the release notes excellent! They provide easy-to-understand descriptive explanations, which actually help the user. ┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Introductory notebook for model developers:
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ If I am prioritizing items from a user perspective, I would have put them in the following order (apologies to doc writers!):
Or perhaps "QuickStart improvements" should go in the Documentation section of the release notes? If so, one could argue that Introductory notebook for model developers should also go in the Documentation ┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Support for external models:
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Custom metric function decorators
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section New documentation template editor
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Enhancements - Add extra columns on the fly
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Enhancements - Support for metadata in new metric decorator
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Enhancements - Associate findings with a documentation section
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Enhancements - Better UI for workflow customization
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Enhancements - Specify a template for rich text custom fields
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ Section Documentation - More contextual information in Jupyter notebooks
┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ General question: do we need an Enhancements section? Why not just a list of items of what's new? Or is the intent to separate out something brand new from a change to an existing thing? ┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄ As always, this feedback are just suggestions. The document owner(s) should decide what, if any, to utilize. I won't be offended if any suggestions are ignored. :) |
No, only the release notes themselves should be reviewed. If you do spot an issue with any of the linked-to items, I'd capture that in a Shortcut story.
Reordered as suggested! The QuickStart video actually started out in the "Documentation" section and it's back there now.
One thing these release notes need more of is related links. In this case, I added links to our developer documentation. Not ideal as it's just reference, but much the info is there.
Added a bit of info but note the callouts are now buttons.
I'll have to re-test but these videos should work. We copy them over as part of the docs site deploy.
In this case, probably not, as the release notes are just the tip of the iceberg. A related link should tell you more, if you are interested.
Unless the developer has provided something, creating more visuals for release notes gets expensive fast. Typically, all the curated release highlights should have visuals or they get bumped into the enhancements section. @even-steven do you know you're in the release notes? 😁
We just take you to JupyterHub. In some older release notes I think I added individual links to notebooks but it's quite extra effort at this point as we have so many of them. There's likely an improvement to be hard here, but it won't be in these release notes.
The Great feedback, thank you! |
|
OK, so these release notes are done, I think, unless there is review input from @mehdi0501 or @cachafla. The docs demo site has the latest changes. One other thing new in these release notes is a more prominent CTA to try stuff out. For example:
|
|
@nrichers Nice! I like the buttons. The only thing is this section which looks a little wonky in the columns (especially as the first paragraph has a colon at the end, indicating... look to the right / bottom?). EDIT: Just pushed a commit with these changes, if you're OK with them!
|
|
Oooh nice. You're more than welcome to use the demo videos that I've made, but keep in mind that they were meant to be an "internal" demo. So there might be things in there that needs to be edited out. Besides that, looks great! |
Thank you, @validbeck! Agreed, this looks better. The main issue is that we don't have a whole lot of content and just some screenshots, so trying to make that look decent is a bit of a challenge. |
robinzimmermann
left a comment
There was a problem hiding this comment.
LGTM, but there are 3 outstanding comments that should be addressed.
Co-authored-by: Robin Zimmermann <[email protected]>
…lidmind/documentation into nrichers/sc-4370/release-notes-update




Internal Notes for Reviewers
This PR includes the release notes up to Sprint 49 for the following tags:
Notes
This is the first release that uses our new ChatGPT-enabled release notes script. The basic process I followed:
make release-notesThere are some consistency issues for both text and images & videos, but the intent here is to put together a lot of different kinds of info with less effort — speed over perfection.
Output
A preview is available on the docs demo site.
External Release Notes