Skip to content

New "Assign documentation section statuses" page in Guides#197

Merged
validbeck merged 1 commit intomainfrom
beck/sc-4030/documentation-add-documentation-section-status
May 22, 2024
Merged

New "Assign documentation section statuses" page in Guides#197
validbeck merged 1 commit intomainfrom
beck/sc-4030/documentation-add-documentation-section-status

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

@validbeck validbeck commented May 21, 2024

Internal Notes for Reviewers

For sc-4030, added a Assign documentation section statuses page.

Assign documentation section statuses

  • Net new page: documentation-section-statuses.qmd
  • Added page to _quarto.yml under "Assign section statuses"
Screenshot 2024-05-21 at 12 18 56 PM

Working with model documentation

  • Updated the contents to include "Assign documentation section statuses" so it shows up in the What's next section
  • Modified the instructions in the Get started section to reflect current UX, including a call-out for documentation summaries at the top of the overview page
Old New
Screenshot 2024-05-21 at 12 19 44 PM Screenshot 2024-05-21 at 12 20 02 PM

@validbeck validbeck added the internal Not to be externalized in the release notes label May 21, 2024
@validbeck validbeck self-assigned this May 21, 2024
@validbeck validbeck requested a review from nrichers May 21, 2024 19:20
@validbeck
Copy link
Copy Markdown
Collaborator Author

validbeck commented May 21, 2024 •
edited
Loading

@nrichers I feel like I sort of anticipated the work in sc-3831 with this one (with the call-out), so I will go ahead and snag that Story from you and make a modification to this page to go over the Document Overview updates. :)

Edit: See PR-#198.

@validbeck validbeck force-pushed the beck/sc-4030/documentation-add-documentation-section-status branch from 8d63329 to c7fb2df Compare May 22, 2024 21:49
@validbeck
Copy link
Copy Markdown
Collaborator Author

validbeck commented May 22, 2024

@nrichers This was overlapped by PR-#198 but then I realised I missed a broken link to the new assign statuses file as well as one of the listing cards before merging into main, so I've taken care of it via this open PR by merging the newest changes from the other PR into this one before making adjustments.

You're only reviewing and approving the following:

Link out to assign statuses page Listing card at the bottom of the page
Screenshot 2024-05-22 at 2 48 07 PM Screenshot 2024-05-22 at 2 47 57 PM

nrichers
nrichers approved these changes May 22, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this PR got updated halfway through my review as there seems to be less in it now. 😁

@validbeck validbeck merged commit 41bc16b into main May 22, 2024
@validbeck validbeck deleted the beck/sc-4030/documentation-add-documentation-section-status branch May 22, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrichers nrichers nrichers approved these changes

Assignees

@validbeck validbeck

Labels

internal Not to be externalized in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@validbeck @nrichers