Conversation
There was a problem hiding this comment.
LGTM! One comment about what the preferred practice should be for compound URLs (URLs that are part variable, part URL path). ![]()
Also, I missed this in my review of your first PR, but we broke all the ze buttons, as variables inside of HTML do not work. For example, I fixed this yesterday:
(Fixed in my https://github.com/validmind/documentation/tree/nrichers/sc-4580/bny-create-training-collateral branch and already fixed on the prod branch as a temporary measure.)
Oh durr, thanks for catching that.
Great point, I'll keep an eye out. |
Internal Notes for Reviewers
Edge cases
Anything remaining in the site
.qmdfiles that come up in searches for these are because:framework: They are referencing a different kind of framework, such as "governance framework" in regulatory guidance discussions