Skip to content

Pulling PR#110 from developer-framework into documentation#216

Merged
validbeck merged 4 commits intomainfrom
beck/quickstart-code-snippet
Jun 13, 2024
Merged

Pulling PR#110 from developer-framework into documentation#216
validbeck merged 4 commits intomainfrom
beck/quickstart-code-snippet

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

@validbeck validbeck commented Jun 11, 2024

Internal Notes for Reviewers

See PR#110 from developer-framework for more details

I spot-checked these pages as per the "Publish the docs site" Notion guide:

  • Top nav links correctly to each section
  • Get started with the ValidMind Developer Framework
  • Run tests and test suites
  • Code samples (including download button)
  • ValidMind Developer Framework (Python docs)
  • Test descriptions

index.qmd

I also fixed the links out to the FAQ and the Request a Demo page. They now link to:

@validbeck validbeck added the internal Not to be externalized in the release notes label Jun 11, 2024
@validbeck validbeck self-assigned this Jun 11, 2024
@validbeck validbeck requested review from noosheenv and nrichers June 11, 2024 16:41
@validbeck
Copy link
Copy Markdown
Collaborator Author

Also pulled in the latest changes from PR#114 over in developer-framework and retested all the major pages, notebook downloads, etc.

@validbeck
Copy link
Copy Markdown
Collaborator Author

Pulled in the latest changes from main from developer-framework PR-121 as well.

Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thank you for much for pulling together this PR on short notice and also including some other fixes that we need until I merge the training PR. Merci!

@validbeck validbeck merged commit 8515441 into main Jun 13, 2024
@validbeck validbeck deleted the beck/quickstart-code-snippet branch June 13, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants