Skip to content

Changed instances of Group Admin or Superuser to Customer Admin#224

Merged
noosheenv merged 1 commit intomainfrom
noosheenvazinkhoo/sc-5058/change-instances-of-group-admin-superuser
Jun 21, 2024
Merged

Changed instances of Group Admin or Superuser to Customer Admin#224
noosheenv merged 1 commit intomainfrom
noosheenvazinkhoo/sc-5058/change-instances-of-group-admin-superuser

Conversation

@noosheenv
Copy link
Copy Markdown
Contributor

Internal Notes for Reviewers

There were a few instances in the Onboarding Users section that mention Group Admin or Superuser, so I replaced them with Customer Admin. Mentions of Group Admin were removed completely in the definitions section.

Before After
Screenshot 2024-06-21 at 10 21 38 AM image
image image

The following changes have already been merged, but relate to this story:
The Onboarding users page was pretty rough. I removed the Example section, and replaced it with a What's next section with CTA cards.

Before After
image image

Sidenote: I tried to add only the changed files like Nik said, so let me know if the Git diff experience is better!

External Release Notes

@noosheenv noosheenv added the internal Not to be externalized in the release notes label Jun 21, 2024
@noosheenv noosheenv requested review from nrichers and validbeck June 21, 2024 18:36
@noosheenv noosheenv self-assigned this Jun 21, 2024
@noosheenv
Copy link
Copy Markdown
Contributor Author

After looking through the other docs in this section, I realized that a lot of the steps in bullet points should be in their own section as numbered steps, like the one in the Manage roles guide. Should I make a new PR, or edit this story to include this restructuring?

Copy link
Copy Markdown
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The "Onboarding users" page looks great now. You can go ahead and render the files and send them up I think, before you merge the commit in (gives you and opportunity to check the major links in the site as well to make sure they work in the static files, catch any missed merge conflicts, etc.)

I realized that a lot of the steps in bullet points should be in their own section as numbered steps, like the one in the Manage roles guide. Should I make a new PR, or edit this story to include this restructuring?

I think you can make a new Story to review the guides in this section yes, as you are likely needing to retool Manage users into at least 2 new articles!

@noosheenv noosheenv merged commit 8a7b58a into main Jun 21, 2024
@noosheenv noosheenv deleted the noosheenvazinkhoo/sc-5058/change-instances-of-group-admin-superuser branch June 21, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants