Skip to content

Update site banner#249

Merged
nrichers merged 2 commits intomainfrom
nrichers-patch-1
Jul 15, 2024
Merged

Update site banner#249
nrichers merged 2 commits intomainfrom
nrichers-patch-1

Conversation

@nrichers
Copy link
Copy Markdown
Collaborator

@nrichers nrichers commented Jul 15, 2024 •
edited
Loading

Internal Notes for Reviewers

Love our new banner! Here's some small text tweaks I'd like to suggest:

  • Group like things together to reduce segmentation ('gain hands-on experience & training env' go closely together)
  • End the text cleanly with the main CTA ('explore what VM has to offer')
  • Remove period at the end as banners typically shouldn't have one, similar to UI toasts

EDIT: An even simpler banner would be "Try our training environment to explore what ValidMind has to offer" — what do you think?

EDIT EDIT: I'm gonna push a commit for the even simpler banner.

External Release Notes

@nrichers nrichers added the internal Not to be externalized in the release notes label Jul 15, 2024
@nrichers nrichers requested a review from validbeck July 15, 2024 17:43
validbeck
validbeck approved these changes Jul 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@validbeck validbeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try our training environment to explore what ValidMind has to offer

I like this! Either works for me, I just stole the first line from the training landing page when I made the announcement 😅

Remove period at the end as banners typically shouldn't have one, similar to UI toasts

Is there some documentation on this (or some style guides that follow this convention) so I can read up on it to familarise myself? It just looks strange without the period here but I'm sure you're correct!

EDIT: For some reason the callout-appearance displays a bit strangely with the CSS when it's not set to simple, BTW. 🤔 It was intermittent when I tried it, though, like it happened once then not again.

@nrichers
Copy link
Copy Markdown
Collaborator Author

nrichers commented Jul 15, 2024

Is there some documentation on this (or some style guides that follow this convention) so I can read up on it to familarise myself? It just looks strange without the period here but I'm sure you're correct!

When I spun up the UX team at Elastic, I got my lead UX writer to work on related writing guidelines for the designers: https://eui.elastic.co/#/guidelines/writing/guidelines#punctuation — look under "Don't use unneccessary punctuation".

@nrichers
Copy link
Copy Markdown
Collaborator Author

nrichers commented Jul 15, 2024

EDIT: For some reason the callout-appearance displays a bit strangely with the CSS when it's not set to simple, BTW. 🤔 It was intermittent when I tried it, though, like it happened once then not again.

I didn't touch this, looks like GitHub just stripped out an extra line break?

@nrichers nrichers merged commit 0cfcf08 into main Jul 15, 2024
@nrichers nrichers deleted the nrichers-patch-1 branch July 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@validbeck validbeck validbeck approved these changes

Assignees

No one assigned

Labels

internal Not to be externalized in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nrichers @validbeck