Fiddled with callout & link padding, edited README#250
Merged
Conversation
nrichers
reviewed
Jul 15, 2024
Collaborator
nrichers
left a comment
There was a problem hiding this comment.
LGTM! 🚀
the thickened underline it looks better (and more cohesive) closer to the text (and a bit artsy, too
I've never seen underlines referred to as "artsy" but I'll take it! 🎨 🖌️
Collaborator
Author
|
@nrichers Thank you for the quick review! However, it doesn't seem like you actually pressed the "Approve" button, can you do that when you have a moment? 😅 |
nrichers
approved these changes
Jul 15, 2024
Collaborator
|
My apologies, @validbeck! Should be approved now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
Added some padding to callout titles
Updated README
I noticed today during the demo that
developer-frameworkfolder in the directory reference should actually just bedeveloper, so I fixed that.Adjusted link underline padding
I removed the additional padding for the link underlines as I actually realised that with the thickened underline it looks better (and more cohesive) closer to the text (and a bit artsy, too).