Conversation
noosheenv
left a comment
There was a problem hiding this comment.
I think this looks good, but we should wait for Nik to look just in case!
nrichers
left a comment
There was a problem hiding this comment.
Can we agree that nothing should live in site/ that isn't part of the public site?
For this PR, I think this means moving /site/wip up a level or deleting. I know search is set to false for these files, but there's no reason to build and externalize them at all, as they are just old cruft.
(I'd be fine with going one step further and just deleting that wip folder. All of the content in there is experimental from last year and largely defunct in its current form.)
Fine by me! I just wasn't sure if you had any plans for the stuff in there that felt more fleshed out. I think I will keep the mermaid diagrams and put it into templates as a reference but otherwise I'm good with nixing the rest. |
35057ef to
9556bdb
Compare
Internal Notes for Reviewers
Things moved
WIP
site/wip(searchset tofalse). These were either upcoming product docs that had a nice skeleton or some conceptual docs we might want to revisit.@nrichers Let me know if you'd prefer to unthink-therefore-unam these bad boys and we can do that:
conceptualproductmermaid-diagrams-dev-framework.qmdeditions-and-features.qmd(Refer to Slack conversation here.)mrm-lifecycle.qmdmrm-three-lines-of-defense.qmdmrm.qmd/internal
Slight edits
/faq/faq-privacy.qmdpage as there was one line from the duplicate file not present on this surfaced filerelease-notes.qmdfor2024-may-22so I resolved thateditions-and-features.qmdfile and found that the.column-screen-inset-rightdidn't actually look too great so I removed it/internal/testing.qmd(theinternalfolder OUTSIDE ofsiteinstead of into the now non-existingsite-unused)Comparisons
*Just my VSCode preview theming, not to worry about the red.