Skip to content

Fixed broken mp4 files in docs site#265

Merged
validbeck merged 5 commits intomainfrom
beck/sc-5548/fix-broken-mp4-files-in-docs-site
Aug 6, 2024
Merged

Fixed broken mp4 files in docs site#265
validbeck merged 5 commits intomainfrom
beck/sc-5548/fix-broken-mp4-files-in-docs-site

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

Internal Notes for Reviewers

For sc-5548, I moved all of our videos, stylesheets, and fonts into the assets folder to resolve the issue where videos were not being pulled into the rendered _site files.

You can see the changes up on: https://docs-demo.vm.validmind.ai/ (Particularly on this releases page: https://docs-demo.vm.validmind.ai/releases/2024-mar-27/highlights.html)

Make sure to empty cache & hard reload to see changes:

  1. Right-click, select Inspect.
  2. Long press your refresh button in your browser toolbar.
  3. Click Empty Cache and Hard Reload.

Net-new section in README.md

Screenshot 2024-08-06 at 12 39 21 PM

@validbeck validbeck added the internal Not to be externalized in the release notes label Aug 6, 2024
@validbeck validbeck self-assigned this Aug 6, 2024
@validbeck validbeck requested review from noosheenv and nrichers August 6, 2024 19:43
Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments around simplifying the instructions a bit.

@validbeck validbeck merged commit 19befff into main Aug 6, 2024
@validbeck validbeck deleted the beck/sc-5548/fix-broken-mp4-files-in-docs-site branch August 6, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants