Skip to content

Added make install to the Makefile to install dependencies#271

Merged
validbeck merged 1 commit intomainfrom
noosheenvazinkhoo/sc-5846/fix-makefile-to-run-make-install
Aug 14, 2024
Merged

Added make install to the Makefile to install dependencies#271
validbeck merged 1 commit intomainfrom
noosheenvazinkhoo/sc-5846/fix-makefile-to-run-make-install

Conversation

@noosheenv
Copy link
Copy Markdown
Contributor

Internal Notes for Reviewers

There was an issue with some dependencies not being installed within the cloned little folder of the developer-framework repo.

By adding make install to the Makefile, dependencies are installed and the scripts can run normally.

External Release Notes

@noosheenv noosheenv added the internal Not to be externalized in the release notes label Aug 13, 2024
@noosheenv noosheenv requested a review from nrichers August 13, 2024 16:34
@noosheenv noosheenv self-assigned this Aug 13, 2024
@github-actions
Copy link
Copy Markdown
Contributor

PR Summary

This pull request enhances the test-descriptions target in the Makefile by adding a make install command before running the extract_descriptions.py script. This ensures that all necessary dependencies are installed before the script is executed, which can help prevent runtime errors due to missing dependencies.

Test Suggestions

  • Run the make test-descriptions command to ensure that the make install step completes successfully and that the extract_descriptions.py script runs without errors.
  • Verify that the test-descriptions target correctly updates the test descriptions source as expected.
  • Check if the make install command introduces any new dependencies or changes to the environment that could affect other parts of the build process.

@noosheenv
Copy link
Copy Markdown
Contributor Author

Just tested on a fresh clone of the repo, and it works! Basically on the command line I ran:

git clone https://github.com/validmind/documentation
cd documentation
cd site

And then I wanted to test running make get-source without the changes to see that it fails

make get-source

and it failed successfully! So then I edited the Makefile:

vim Makefile

And then ran it again to see if it got fixed:

make get-source

And it did!! woohoo

@noosheenv noosheenv requested a review from validbeck August 13, 2024 23:25
Copy link
Copy Markdown
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this on a very fresh clone of the repo — it works, installs everything and dumps out the correct output!!

Running make get-source a second time bypasses the install as well as everything is already there.

@validbeck validbeck merged commit 50ee15d into main Aug 14, 2024
@validbeck validbeck deleted the noosheenvazinkhoo/sc-5846/fix-makefile-to-run-make-install branch August 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants