Skip to content

Resolved janky footer styling#468

Merged
validbeck merged 1 commit intomainfrom
beck/sc-6988/investigate-janky-footer-footnotes-styling
Oct 9, 2024
Merged

Resolved janky footer styling#468
validbeck merged 1 commit intomainfrom
beck/sc-6988/investigate-janky-footer-footnotes-styling

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

@validbeck validbeck commented Oct 9, 2024 •
edited
Loading

Internal Notes for Reviewers

sc-6988

It was all my bad, I added some janky margin padding to the footer when I should have added it to the index-locked releases div. Should be good now: LIVE PREVIEW

@validbeck validbeck added the internal Not to be externalized in the release notes label Oct 9, 2024
@validbeck validbeck self-assigned this Oct 9, 2024
@validbeck validbeck requested a review from nrichers October 9, 2024 18:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2024

PR Summary

This pull request introduces changes to the CSS styling of the website. Specifically, it adjusts the margin-bottom property for preformatted text elements (pre, pre.python, pre.bash, pre.yaml) from -30px to -80px. Additionally, it removes the margin-top property from the .nav-footer class, which was previously set to -50px. These changes are likely intended to improve the layout and spacing of these elements on the page.

Test Suggestions

  • Verify that the preformatted text elements display correctly with the new margin-bottom setting across different browsers and screen sizes.
  • Check that the removal of the margin-top from the .nav-footer class does not negatively impact the layout of the footer section.
  • Ensure that the overall page layout remains consistent and visually appealing after these CSS changes.

@validbeck validbeck changed the title I fixed it Resolved janky footer styling Oct 9, 2024
nrichers
nrichers approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checked the preview and looks good. 🚀

@validbeck validbeck merged commit d750757 into main Oct 9, 2024
@validbeck validbeck deleted the beck/sc-6988/investigate-janky-footer-footnotes-styling branch October 9, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrichers nrichers nrichers approved these changes

Assignees

@validbeck validbeck

Labels

internal Not to be externalized in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@validbeck @nrichers