Skip to content

Adjusting training styles#497

Merged
validbeck merged 3 commits intomainfrom
beck/training-adjusts
Oct 28, 2024
Merged

Adjusting training styles#497
validbeck merged 3 commits intomainfrom
beck/training-adjusts

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

@validbeck validbeck commented Oct 28, 2024

Internal Notes for Reviewers

Cleaned up the neat training edits Nik set up!

LIVE PREVIEW

Index Academy section

Screenshot 2024-10-28 at 2 33 09 PM

Training landing

Just made sure the admin training was all in one line:

Screenshot 2024-10-28 at 2 41 10 PM

Added the author & reading time to the notebooks:

Screenshot 2024-10-28 at 2 57 22 PM

Style guide reference

Screenshot 2024-10-28 at 3 10 27 PM

@validbeck validbeck added the internal Not to be externalized in the release notes label Oct 28, 2024
@validbeck validbeck self-assigned this Oct 28, 2024
@validbeck validbeck changed the title Beck/training adjusts Adjusting training styles Oct 28, 2024
@github-actions
Copy link
Copy Markdown
Contributor

A PR preview is available: Preview URL

Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the pink bar gets removed again on the .preview tiles — thank you for improving the training improvements further. 🚀

@github-actions
Copy link
Copy Markdown
Contributor

A PR preview is available: Preview URL

@validbeck validbeck merged commit 8ae79c7 into main Oct 28, 2024
@validbeck validbeck deleted the beck/training-adjusts branch October 28, 2024 23:19
@nrichers
Copy link
Copy Markdown
Collaborator

@validbeck this has been merged but one other comment after-the-fact: I'd like to start developing a slightly different feel for the training content to help set it apart from other content. I think this might mean slightly less pink and perhaps more dark cyan than we have in our other content. E.g. not having a pink border around the training previews was actually intentional and was meant to keep the new preview extension as generic as possible, though it's now back. Perhaps something to chat about at one of our stand-ups, to agree roughly on what the future direction might be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants