Skip to content

Quick gallery css#517

Merged
validbeck merged 2 commits intomainfrom
beck/lightbox-experiments
Nov 8, 2024
Merged

Quick gallery css#517
validbeck merged 2 commits intomainfrom
beck/lightbox-experiments

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

Internal Notes for Reviewers

Old New
old new

@validbeck validbeck added the internal Not to be externalized in the release notes label Nov 7, 2024
@validbeck validbeck self-assigned this Nov 7, 2024
@validbeck validbeck requested a review from nrichers November 7, 2024 22:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 7, 2024

PR Summary

This pull request introduces a new Lightbox gallery feature to the project. The Lightbox gallery is defined in a new file internal/testing/lightbox.qmd, which includes a set of images grouped together for display. The gallery is styled using CSS classes to ensure a consistent and visually appealing presentation.

Key changes include:

  • Creation of a new Lightbox gallery in internal/testing/lightbox.qmd with three images, each wrapped in a responsive container.
  • Updates to the site/_quarto.yml file to include the new Lightbox gallery in the website configuration.
  • Addition of new CSS styles in site/styles.css to customize the appearance of the Lightbox gallery, including button colors, hover effects, and description backgrounds.

These changes enhance the visual presentation of images on the site and provide a more interactive user experience.

Test Suggestions

  • Verify that the Lightbox gallery displays correctly with all images in internal/testing/lightbox.qmd.
  • Check the responsiveness of the Lightbox gallery on different screen sizes.
  • Test the CSS styling changes to ensure buttons and hover effects appear as expected.
  • Ensure that the Lightbox gallery is correctly linked and accessible from the main site navigation.
  • Validate that the Lightbox functionality works across different browsers.

Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@validbeck validbeck merged commit 6226f4a into main Nov 8, 2024
@validbeck validbeck deleted the beck/lightbox-experiments branch November 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants