Skip to content

Quick adjustment to hero BG img for training #520

Merged
validbeck merged 1 commit intomainfrom
beck/hero-banners
Nov 13, 2024
Merged

Quick adjustment to hero BG img for training #520
validbeck merged 1 commit intomainfrom
beck/hero-banners

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

Internal Notes for Reviewers

I noticed during the demo video that was filmed the BG img for the training hero banner repeats instead of being seamless. Fixed now.

Old New
Screenshot 2024-11-12 at 2 06 04 PM Screenshot 2024-11-12 at 2 06 28 PM

@validbeck validbeck added the internal Not to be externalized in the release notes label Nov 12, 2024
@validbeck validbeck self-assigned this Nov 12, 2024
@validbeck validbeck requested a review from nrichers November 12, 2024 22:48
@github-actions
Copy link
Copy Markdown
Contributor

PR Summary

This pull request introduces an enhancement to the CSS styling of the training site. Specifically, it adds the background-size: cover; property to the CSS rules for elements with a hover state. This change ensures that background images are scaled to cover the entire element, maintaining their aspect ratio and filling the element's space without distortion. This enhancement improves the visual presentation of elements with background images when hovered over.

Test Suggestions

  • Verify that elements with background images scale correctly to cover the entire element on hover.
  • Check that the aspect ratio of background images is maintained when the background-size: cover; property is applied.
  • Ensure that the change does not affect other styling properties or cause layout issues on different screen sizes.
  • Test the hover effect across different browsers to ensure consistent behavior.

Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@validbeck validbeck merged commit 56ef50e into main Nov 13, 2024
@validbeck validbeck deleted the beck/hero-banners branch November 13, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants