Skip to content

Replace Output Template Notebook from Highlighted Code Samples#539

Merged
validbeck merged 2 commits intomainfrom
john/remove-output-templates-notebook
Nov 26, 2024
Merged

Replace Output Template Notebook from Highlighted Code Samples#539
validbeck merged 2 commits intomainfrom
john/remove-output-templates-notebook

Conversation

@johnwalz97
Copy link
Copy Markdown
Contributor

@johnwalz97 johnwalz97 commented Nov 21, 2024 •
edited
Loading

Internal Notes for Reviewers

Since we are dropping support for output templates, the code sample notebook for output templates is no longer relevant. This change replaces it with a more relevant notebook on integrating external test providers.

External Release Notes

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@johnwalz97 johnwalz97 added internal Not to be externalized in the release notes deprecation Feature to be removed for the release notes labels Nov 21, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 21, 2024

PR Summary

This pull request updates a reference in the developer guide documentation. Specifically, it changes the path of a notebook in the get-started-validmind-library.qmd file from customization/customizing_tests_with_output_templates.ipynb to custom_tests/integrate_external_test_providers.ipynb. This change likely reflects an update in the organization or content of the code samples, ensuring that the documentation points to the correct and intended resource.

Test Suggestions

  • Verify that the new notebook path custom_tests/integrate_external_test_providers.ipynb exists and is accessible.
  • Check that the content of the new notebook is relevant and correctly linked in the context of the documentation.
  • Ensure that the documentation builds correctly without errors after the path update.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 21, 2024

A PR preview is available: Preview URL

validbeck
validbeck approved these changes Nov 21, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnwalz97!

Looks like we were already using the external test provider notebook in most other places, so this should be sufficient.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 22, 2024

A PR preview is available: Preview URL

@validbeck validbeck merged commit 6ee0dcc into main Nov 26, 2024
@validbeck validbeck deleted the john/remove-output-templates-notebook branch November 26, 2024 01:16
@validbeck validbeck mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@validbeck validbeck validbeck approved these changes

@cachafla cachafla Awaiting requested review from cachafla

Assignees

No one assigned

Labels

deprecation Feature to be removed for the release notes internal Not to be externalized in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnwalz97 @CLAassistant @validbeck