Conversation
Contributor
|
A PR preview is available: Preview URL |
Collaborator
Author
|
@nrichers It still doesn't work. I truly give up. 💀 Something about the staging & prod deploys being triggered by the "merge" workflows behaves entirely differently: |
Collaborator
Here's the song: https://open.spotify.com/track/5KqldkCunQ2rWxruMEtGh0?si=5874cb1fafde4abd Let's chat a bit at our standup today to figure out how we can work around this issue, but happy to go with whatever compromise you think is reasonable. And thank you for putting in all the work into these workflows! 🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Internal Notes for Reviewers
Apparently the workflows don't like
origin/{branch}... SO I am trying ONE MORE THING, and if this doesn't work @nrichers you might have to take over. Stupid workflows.Ensuring we fetch all the branches when we check out the repo:
Just using
stagingasbaseinstead oforigin/staging:To reiterate, the issue isn't the heap tracking/execution profiles, it's filtering for changed files in the notebooks folder when we merge into
stagingandprodvia our workflows/publication step. The only way to get rid of the complexity is to remove this filter and up the render time regardless of whether or not the notebooks have been updated.