Skip to content

Filtering for changes on prod/staging#564

Merged
validbeck merged 1 commit intomainfrom
beck/not-giving-up
Dec 4, 2024
Merged

Filtering for changes on prod/staging#564
validbeck merged 1 commit intomainfrom
beck/not-giving-up

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

Internal Notes for Reviewers

Apparently the workflows don't like origin/{branch}... SO I am trying ONE MORE THING, and if this doesn't work @nrichers you might have to take over. Stupid workflows.

Ensuring we fetch all the branches when we check out the repo:

- name: Check out repository
  uses: actions/checkout@v2
  with:
    fetch-depth: 0  # Fetch all branches

Just using staging as base instead of origin/staging:

# See if site/notebooks/ has updates
# Checks against the previous commit to staging prior to the current push event
- name: Filter changed files
  if: ${{ steps.fetch_staging.outcome == 'success' }}
  uses: dorny/paths-filter@v2
  id: filter
  with:
    base: staging
    ref: ${{ github.sha }}
    filters: |
      notebooks:
              - 'site/notebooks/**'

To reiterate, the issue isn't the heap tracking/execution profiles, it's filtering for changed files in the notebooks folder when we merge into staging and prod via our workflows/publication step. The only way to get rid of the complexity is to remove this filter and up the render time regardless of whether or not the notebooks have been updated.

@validbeck validbeck added the internal Not to be externalized in the release notes label Dec 3, 2024
@validbeck validbeck self-assigned this Dec 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2024

A PR preview is available: Preview URL

Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍿🍿🍿

@validbeck validbeck merged commit 1cef422 into main Dec 4, 2024
@validbeck validbeck deleted the beck/not-giving-up branch December 4, 2024 00:47
@validbeck
Copy link
Copy Markdown
Collaborator Author

@nrichers It still doesn't work. I truly give up. 💀

Something about the staging & prod deploys being triggered by the "merge" workflows behaves entirely differently:

Screenshot 2024-12-03 at 5 15 39 PM

@nrichers
Copy link
Copy Markdown
Collaborator

nrichers commented Dec 4, 2024

@nrichers It still doesn't work. I truly give up. 💀


Here's the song: https://open.spotify.com/track/5KqldkCunQ2rWxruMEtGh0?si=5874cb1fafde4abd

Let's chat a bit at our standup today to figure out how we can work around this issue, but happy to go with whatever compromise you think is reasonable. And thank you for putting in all the work into these workflows! 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants