Removing the workflow filters for staging & prod#572
Merged
Conversation
Contributor
PR SummaryThis pull request simplifies the GitHub Actions workflows for deploying documentation to production and staging environments. The changes involve removing unnecessary steps that fetch branches and filter changed files. Specifically, the following modifications were made:
These changes streamline the workflow by removing redundant operations, potentially reducing execution time and complexity. Test Suggestions
|
Contributor
|
A PR preview is available: Preview URL |
nrichers
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Internal Notes for Reviewers
Yeah, I gave up and just removed the filter for changed files on the
stagingandprodworkflows.Here's the follow-up story in case you want to take a stab at it, @nrichers: https://app.shortcut.com/validmind/story/7680/have-staging-prod-workflows-filter-so-that-they-only-execute-notebooks-when-notebooks-are-changed