Skip to content

Removing the workflow filters for staging & prod#572

Merged
validbeck merged 1 commit intomainfrom
beck/removing-workflow-filters
Dec 5, 2024
Merged

Removing the workflow filters for staging & prod#572
validbeck merged 1 commit intomainfrom
beck/removing-workflow-filters

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

Internal Notes for Reviewers

Yeah, I gave up and just removed the filter for changed files on the staging and prod workflows.

Here's the follow-up story in case you want to take a stab at it, @nrichers: https://app.shortcut.com/validmind/story/7680/have-staging-prod-workflows-filter-so-that-they-only-execute-notebooks-when-notebooks-are-changed

@validbeck validbeck added the internal Not to be externalized in the release notes label Dec 4, 2024
@validbeck validbeck self-assigned this Dec 4, 2024
@validbeck validbeck requested a review from nrichers December 4, 2024 23:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 4, 2024

PR Summary

This pull request simplifies the GitHub Actions workflows for deploying documentation to production and staging environments. The changes involve removing unnecessary steps that fetch branches and filter changed files. Specifically, the following modifications were made:

  • In both deploy-docs-prod.yaml and deploy-docs-staging.yaml:
    • Removed the fetch-depth: 0 option from the actions/checkout@v2 step, which was previously fetching the entire history.
    • Eliminated the steps that fetched the prod and staging branches, respectively.
    • Removed the use of dorny/paths-filter@v2 to check for updates in the site/notebooks/ directory.
    • The conditional creation of the .env file based on the presence of changes in site/notebooks/ was also removed, making the .env file creation unconditional.

These changes streamline the workflow by removing redundant operations, potentially reducing execution time and complexity.

Test Suggestions

  • Verify that the documentation deployment workflows still execute successfully without the removed steps.
  • Check that the .env file is created unconditionally in both production and staging workflows.
  • Ensure that the removal of the fetch and filter steps does not affect the deployment process or introduce any errors.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 4, 2024

A PR preview is available: Preview URL

Copy link
Copy Markdown
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@validbeck validbeck merged commit 71d4575 into main Dec 5, 2024
@validbeck validbeck deleted the beck/removing-workflow-filters branch December 5, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants