Merged
Conversation
2b3094a to
44daca4
Compare
44daca4 to
5d09c8a
Compare
Contributor
PR SummaryThis pull request removes the The change simplifies the Makefile by eliminating a deployment option that may no longer be necessary or used, potentially reducing maintenance overhead and the risk of deploying to an incorrect environment. Test Suggestions
|
Contributor
|
A PR preview is available: Preview URL |
1 similar comment
Contributor
|
A PR preview is available: Preview URL |
nibalizer
approved these changes
Mar 21, 2025
nrichers
added a commit
that referenced
this pull request
Mar 21, 2025
Co-authored-by: Nik Richers <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
This PR removes one of those 'we should fix this some day' annoyances that I've spent more time explaining in the last week than it would take to fix. This PR fixes THE LAST PIECE in the puzzle.
Before
We had an extra docs site in the root of the
s3://docs-ci-cd-demobucket that goes back to the very early days of Andres and I experimenting with docs deployment. This site serves no purpose, is not current, and is not used — other than we need in index.html in the root oforigin/for the PR previews to work.You could deploy this site with
make deploy-demo.After
This site has now been deleted, replaced with an index.html that redirects to https://docs-staging.validmind.ai/ if you try to access the root of
origin/. Eventually, we might want to list all the PR previews but for now, not having a stale, defunct docs site kicking around that I have to explain is an improvement.The
make deploy-demois removed in this PR, preventing accidental redeployment of the site.External Release Notes