Skip to content

Updated product terminology — developer-framework repo side #233

Merged
validbeck merged 24 commits intomainfrom
beck/sc-6647/update-product-terminology
Nov 13, 2024
Merged

Updated product terminology — developer-framework repo side #233
validbeck merged 24 commits intomainfrom
beck/sc-6647/update-product-terminology

Conversation

@validbeck
Copy link
Copy Markdown
Collaborator

@validbeck validbeck commented Nov 13, 2024

Internal Notes for Reviewers

sc-6647

  • I scrubbed everything from notebooks, to test descriptions to READMEs for product names and proofread them to make sure they weren't super awkward after the replacement.
  • I also did a bit of light editing for style guide while I was in there if I noticed any glaring inconsistencies.

Python docs

README.pypi.md

I updated this but I'm not sure how to get it on the actual PyPI page...

To do

@validbeck validbeck added the internal Not to be externalized in the release notes label Nov 13, 2024
@validbeck validbeck self-assigned this Nov 13, 2024
@cachafla
Copy link
Copy Markdown
Contributor

cachafla commented Nov 13, 2024

This PR will make make docs work on Mac, but note that make docs already works when it runs on GH actions (Linux) so we can let the repo take care of it: make docs is automatically triggered when we merge PRs into main.

@cachafla
Copy link
Copy Markdown
Contributor

I updated this but I'm not sure how to get it on the actual PyPI page...

It gets published to PyPI when we merge into prod.

Copy link
Copy Markdown
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👏

@validbeck validbeck merged commit c98847a into main Nov 13, 2024
@validbeck validbeck deleted the beck/sc-6647/update-product-terminology branch November 13, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants