add interface: create, delete field and create datasheet by y-t99 · Pull Request #22 · vikadata/vika.java

y-t99 · 2022-05-05T07:25:34Z

add field.create, field.delete and datasheet.create interface and test example.

…ple.

yort-feng · 2022-05-23T12:47:28Z

README.md

+// add description to datasheet
+request.setDescription("description");
+// specify the folder where the datasheet is stored
+request.setFolderId("fod_id");


fod_id——>fold_id

yort-feng · 2022-05-23T13:00:32Z

client/src/main/java/cn/vika/client/api/FieldApi.java

+
+    private void checkDeleteFieldPathArgs(String spaceId, String datasheetId, String fieldId) {
+        if (!StringUtil.hasText(spaceId)) {
+            throw new ApiException("space id must be not null");


must be not null——> must not be null

yort-feng · 2022-05-23T13:02:15Z

README.md

+                .withProperty(singleTextFieldProperty)
+                .build();
+// request to create a field
+CreateFieldResponse response = vikaApiClient.getFieldApi().addField("space_id", "datasheet_id", request);


request object参数保持跟其他示例统一名字：xxxxRequest，比如createFieldRequest。

yort-feng · 2022-05-23T13:02:45Z

README.md

+request.setFields(fields);
+
+// request to create a datasheet
+CreateDatasheetResponse response = vikaApiClient.getDatasheetApi().addDatasheet("space_id", request);


request object参数保持跟其他示例统一名字：xxxxRequest，比如createDatasheetRequest。

yort-feng · 2022-05-23T13:15:20Z

client/src/main/java/cn/vika/client/api/model/field/property/MagicLinkFieldProperty.java

+public class MagicLinkFieldProperty extends BaseFieldProperty {
+
+    private String foreignDatasheetId;
+


删除多于换行

yort-feng · 2022-05-23T13:54:49Z

client/src/main/java/cn/vika/client/api/model/field/property/option/FormatType.java

+     * Format about Currency
+     * @see cn.vika.client.api.model.field.property.option.CurrencyFormat
+     */
+    Currency("Currency"),


syntax error

yort-feng · 2022-05-23T14:32:51Z

client/src/main/java/cn/vika/client/api/model/field/property/option/TypeFormat.java

+/**
+ * @author tao
+ */
+public abstract class TypeFormat {


TypeFormat这个抽象类什么参数都没有，它存在的意义是什么？

yort-feng · 2022-05-23T14:33:47Z

client/src/main/java/cn/vika/client/api/model/field/property/option/TimeFormatEnum.java

+/**
+ * @author tao
+ */
+public enum TimeFormatEnum {


有的枚举命名以Enum结尾，有的没有，需要统一

yort-feng · 2022-05-23T14:49:02Z

client/src/main/java/cn/vika/client/api/VikaApiClient.java

@@ -49,6 +49,10 @@ public class VikaApiClient {

    private NodeApi nodeApi;


赞！双重检查锁定模式需要需要使用 volatile，之前用到双重锁的地方也加上volatile吧。解决两个问题：

保证可见性。使用 volatile 定义的变量，将会保证对所有线程的可见性
禁止指令重排序优化

yort-feng · 2022-05-23T15:22:36Z

README.md

+> more detail about field type and property of field see official [API manual#create-field](https://vika.cn/developers/api/reference/#operation/create-fields)
+
+```java
+// Example 1: create SingleText field


两个Example拆分成两个代码块，参考update record的两个Example

yort-feng · 2022-05-24T08:28:42Z

client/src/main/java/cn/vika/client/api/model/field/FieldTypeEnum.java

+ */
+public enum FieldTypeEnum {
+    /**
+     *


加下注释

shawndenggh

finished

shawndenggh

viewed

Itou-Ng and others added 11 commits May 5, 2022 14:58

feat: field type

8ff011e

feat: add interface: create, delete field and create datasheet.

f110aa8

feat: add CreateFieldRequestBuilder

671bfa8

test: add new interface test: create, delete field and create datasheet.

9c54df0

fix: add lacking setter and getter.

f408d9e

fix: fix field create request parameter bug.

79c38d4

test: add different field create test example

76cd8bf

test: add a datasheet create test example

572e5bb

docs: readme add create field, delete field and create datasheet exam…

b2f2402

…ple.

style: delete unused file.

d557483

docs: add enum's value comment.

d073fb8

yort-feng suggested changes May 23, 2022

View reviewed changes

y-t99 added 3 commits May 24, 2022 15:33

refactor: clear up and beautify code

2fa84ee

fix: Double-checked locking without volatile

d787872

docs: modify example.

c6892c5

yort-feng suggested changes May 24, 2022

View reviewed changes

docs: add some enumerations' explanation.

f9dcb43

yort-feng approved these changes May 24, 2022

View reviewed changes

shawndenggh reviewed May 24, 2022

View reviewed changes

shawndenggh approved these changes May 24, 2022

View reviewed changes

shawndenggh merged commit e26f90e into vikadata:master May 24, 2022

		public class MagicLinkFieldProperty extends BaseFieldProperty {

		private String foreignDatasheetId;

		@@ -49,6 +49,10 @@ public class VikaApiClient {

		private NodeApi nodeApi;

Conversation

y-t99 commented May 5, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawndenggh left a comment

Choose a reason for hiding this comment

Uh oh!

shawndenggh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants