Skip to content

I updated the assignment - 1#1

Open
vikrama33 wants to merge 3 commits intomainfrom
assignment-1
Open

I updated the assignment - 1#1
vikrama33 wants to merge 3 commits intomainfrom
assignment-1

Conversation

@vikrama33
Copy link
Copy Markdown
Owner

@vikrama33 vikrama33 commented Aug 25, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on the right track. The main issue is indentation. Currently, your code can only handle the case when is_case_sensitive is False; you don’t handle the True case explicitly! Please revise

@vikrama33
Copy link
Copy Markdown
Owner Author

@juliagallucci I have updated the code as per your comment
Please advise

Thank you,

Regards
Vik

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're close! For part B, your function won’t run properly because of indentation errors. The way you’ve indented your code makes the return statement only execute when is_case_sensitive is False. If is_case_sensitive is True, the function does nothing (implicitly returns None)! Please revise.

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants