Use Clang format for fomatting by saccarosium · Pull Request #16019 · vim/vim

saccarosium · 2024-11-09T12:15:01Z

This is a resurrection of #15789 and futher discussion were done in #13318.

This PR tries to enforce the code style defined in #15939

saccarosium · 2024-11-18T12:11:01Z

@chrisbra any blockers?

chrisbra · 2024-11-18T18:24:23Z

src/sign.c

+        // Parse command line arguments
+        if (parse_sign_cmd_args(idx, arg, &sign_name, &id, &group, &prio, &buf,
+                                &lnum)
+            == FAIL)


That == FAIL on a separate line looks un-usual

This and the other below should be resolved

chrisbra · 2024-11-18T18:24:53Z

src/sign.c

+        last = p;
+        p = skiptowhite(p);
+    }
+    while (*p != NUL);


That while on a separate line looks also a bit unusual.

chrisbra · 2024-11-18T18:25:11Z

src/sign.c

-	retval = 0;
+    if (sign_define_by_name(name, icon, linehl, text, texthl, culhl, numhl,
+                            prio)
+        == OK)


again here the linebreak before the == OK

chrisbra · 2024-11-18T18:25:45Z

src/sound.c

-                CA_PROP_CANBERRA_CACHE_CONTROL, "volatile",
-                NULL);
+                              playfile ? CA_PROP_MEDIA_FILENAME
+                                       : CA_PROP_EVENT_ID,


too much indent?

If you notice the ? and : are aligned so you can more easily follow the ternary (at least I find that much more readable)

chrisbra · 2024-11-18T18:26:38Z

No, I am checking. Basically fine, I just found some of the formatting a bit unusual.

saccarosium · 2024-11-18T21:32:49Z

Ok I've applied some of your suggestions. I would love to get this merge so I can start doing some refactoring.

This is used in preparation to enable automatic code-formatting in the following commits. For now let's just add a clang-format config file, formatting of source files will follow. related: #16019 Signed-off-by: Luca Saccarola <[email protected]> Signed-off-by: Christian Brabandt <[email protected]>

CI: Bump codecov/codecov-action from 4 to 5 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... closes: vim#16079 Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0870: too many strlen() calls in eval.c Problem: too many strlen() calls in eval.c Solution: Refactor eval.c to remove calls to STRLEN() (John Marriott) closes: vim#16066 Signed-off-by: John Marriott <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0871: getcellpixels() can be further improved Problem: getcellpixels() can be further improved Solution: Fix floating point exception, implement getcellpixels() in the UI (mikoto2000) closes: vim#16059 Signed-off-by: mikoto2000 <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0872: No test for W23 message Problem: No test for W23 message Solution: Check for W23 message when accessing the clipboard fails (after v9.1.0868) closes: vim#16076 Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0873: filetype: Vivado files are not recognized Problem: filetype: Vivado files are not recognized Solution: detect '*.mss' files as 'mss' filetype (Wu, Zhenyu) references: https://docs.amd.com/r/2020.2-English/ug1400-vitis-embedded/Microprocessor-Software-Specification-MSS closes: vim#15907 Signed-off-by: Wu, Zhenyu <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> CI: join codecov array flags, instead of accessing it directly closes: vim#16082 Signed-off-by: rhysd <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0874: filetype: karel files are not detected Problem: filetype: karel files are not detected Solution: detect '*.kl' files as karel filetype, include syntax and filetype plugin (Kirill Morozov) closes: vim#16075 Co-authored-by: KnoP-01 <[email protected]> Signed-off-by: Kirill Morozov <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0875: filetype: hyprlang detection can be improved Problem: filetype: hyprlang detection can be improved Solution: detect '/hypr/*.conf' files as hyprlang filetype, include basic syntax highlighting (Luca Saccarola) fixes: vim#15875 closes: vim#16064 Signed-off-by: Luca Saccarola <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0876: filetype: openCL files are not recognized Problem: filetype: openCL files are not recognized Solution: detect '*.cl' files as opencl or lisp filetype, include a opencl syntax and filetype plugin (Wu, Zhenyu) closes: vim#15825 Signed-off-by: Wu, Zhenyu <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0877: tests: missing test for termdebug + decimal signs Problem: tests: missing test for termdebug + decimal signs Solution: Add a termdebug test (Ubaldo Tiberi) closes: vim#16081 Signed-off-by: Ubaldo Tiberi <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0878: termdebug: cannot enable DEBUG mode Problem: termdebug: cannot enable DEBUG mode Solution: Allow to specify DEBUG mode (Ubaldo Tiberi) closes: vim#16080 Signed-off-by: Ubaldo Tiberi <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> runtime(compiler): fix escaping of arguments passed to :CompilerSet See newly added help entry referring to option-backslash closes: vim#16084 Signed-off-by: Konfekt <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> Add clang-format config file This is used in preparation to enable automatic code-formatting in the following commits. For now let's just add a clang-format config file, formatting of source files will follow. related: vim#16019 Signed-off-by: Luca Saccarola <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0879: source is not consistently formatted Problem: source is not consistently formatted Solution: reformat sign.c and sound.c (Luca Saccarola) closes: vim#16019 Signed-off-by: Luca Saccarola <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> git: ignore re-formatting commit v9.1.0879 for blame Signed-off-by: Christian Brabandt <[email protected]> runtime(doc): add helptag for :HelpToc command Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0880: filetype: C3 files are not recognized Problem: filetype: C3 files are not recognized Solution: detect '*.c3*' files as c3 filetype (Turiiya) closes: vim#16087 Signed-off-by: Turiiya <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> runtime(misc): add Italian LICENSE and (top-level) README file related: vim#16061 Signed-off-by: Antonio Giovanni Colombo <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> runtime(apache): Update syntax keyword definition closes: vim#16105 Signed-off-by: nisbet-hubbard <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> runtime(netrw): update netrw's decompress logic Detect a few more default archive types, correctly handle file extensions with digits in it. fixes: vim#16099 closes: vim#16104 Signed-off-by: Konfekt <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0881: GUI: message dialog may not get focus Problem: GUI: message dialog may not get focus Solution: add window manager hint to give focus to the dialog (Chris White) Tell the window manager that message dialogs should be given focus when the user switches from another application back to Vim. This can happen, e.g., when the user has a file open in Vim and then edits it in another program. fixes: vim#172 closes: vim#16100 Signed-off-by: Chris White <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> patch 9.1.0882: too many strlen() calls in insexpand.c Problem: too many strlen() calls in insexpand.c Solution: Refactor insexpand.c and reduce number of calls to STRLEN(), fix a warning get_next_filename_completion(), add new function ins_compl_leader_len() (John Marriott) closes: vim#16095 Signed-off-by: John Marriott <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> runtime(netrw): Fixing powershell execution issues on Windows closes: vim#16094 Signed-off-by: GuyBrush <[email protected]> runtime(doc): Expand docs on :! vs. :term fixes: vim#16071 closes: vim#16089 Signed-off-by: matveyt <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> rename the files of the chapter one to tutor1 The numbering of lessons in the files of chapter one begins with 1 the files of chapter one

saccarosium added 3 commits November 9, 2024 13:03

add clang-format configuration

fd0d8f5

format sign.c

81552a9

format sound.c

baab669

saccarosium mentioned this pull request Nov 9, 2024

[Tracker]: clearly standardize vim's C coding style #15930

Closed

6 tasks

dundargoc mentioned this pull request Nov 9, 2024

Add formatter #13318

Closed

chrisbra reviewed Nov 18, 2024

View reviewed changes

apply suggestions by chrisbra

d9ad0fe

chrisbra closed this in 3cf094e Nov 19, 2024

saccarosium deleted the clang-format branch November 19, 2024 22:02

This was referenced Nov 24, 2024

Format small header files #16093

Closed

format gui_gtk_f.c #16117

Closed

Shane-XB-Qian mentioned this pull request Dec 25, 2024

fmt: reformat sound.c to noet and unify to vim code base #16299

Closed

h-east mentioned this pull request Apr 30, 2025

Fix indent in insexpand.c #17219

Closed

chrisbra mentioned this pull request Jul 17, 2025

UseTab: Never #17758

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use Clang format for fomatting#16019

Use Clang format for fomatting#16019
saccarosium wants to merge 4 commits intovim:masterfrom
saccarosium:clang-format

saccarosium commented Nov 9, 2024

Uh oh!

saccarosium commented Nov 18, 2024

Uh oh!

chrisbra Nov 18, 2024

Uh oh!

saccarosium Nov 18, 2024

Uh oh!

chrisbra Nov 18, 2024

Uh oh!

saccarosium Nov 18, 2024

Uh oh!

chrisbra Nov 18, 2024

Uh oh!

chrisbra Nov 18, 2024

Uh oh!

saccarosium Nov 18, 2024

Uh oh!

chrisbra commented Nov 18, 2024

Uh oh!

saccarosium commented Nov 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

saccarosium commented Nov 9, 2024

Uh oh!

saccarosium commented Nov 18, 2024

Uh oh!

chrisbra Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

saccarosium Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

chrisbra Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

saccarosium Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

chrisbra Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

chrisbra Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

saccarosium Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

chrisbra commented Nov 18, 2024

Uh oh!

saccarosium commented Nov 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants