fix: expand markdownlint ignore to unblock PRs#64
Conversation
These dirs contain generated/authored content with intentional formatting that shouldn't block CI.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where markdownlint was causing CI failures by incorrectly flagging content in specific directories. By updating the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…stead The hardcoded `globs` in the action config was overriding the .markdownlintignore file, causing lint failures on excluded dirs.
There was a problem hiding this comment.
Code Review
This pull request expands the .markdownlintignore file to exclude more directories from markdown linting, with the goal of unblocking CI. The additions for checklists and .specify/memory seem reasonable given their likely content. However, the pattern for the scripts directory is very broad. I've suggested a more precise alternative that will still allow for linting of any markdown documentation within that directory, making the configuration more robust for the future.
| **/repomix-*.md | ||
| **/checklists/** | ||
| .specify/memory/** | ||
| scripts/** |
There was a problem hiding this comment.
The pattern scripts/** is quite broad. It will prevent any markdown files within the scripts directory (like a README.md) from being linted now or in the future. A more precise approach is to ignore the directory but re-include markdown files for linting. This ensures that documentation is still checked for quality, which can be important for script usage and maintenance.
scripts/
!scripts/**/*.md
Auto-generated file with intentional formatting.
|
Expands
.markdownlintignoreto exclude checklists, .specify/memory, and scripts dirs — these contain generated/authored content with intentional formatting that shouldn't block CI.